Fix select row icon #7598
Merged
Fix select row icon #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is "removed unused css class from mobile wizard" somehow related to the fixed icon visibility? |
|
no that removed class thing is for the mobile view where icon has this wired white background in dark mode. it was a small change so i added here. |
|
I see, best to put separate topics in separate commits so then it is obvious what it does :) (this can be as it is, just for future) |
|
Ahha i see, sorry fo the confusion :) |
Darshan-upadhyay1110
force-pushed
the
private/darshan/fix-select-row-icon
branch
from
ed41b4e
to
7ad47cd
Compare
- SVG for lc_fromrow is not compatable and it was not loading properly in browser - fixed svg syntex to properly load by browser - removed unused css class from mobile wizard - that fixes the icon remain light in mobile view as well Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: Ifa1e2e5397e48d33ede8a6081808cd0051d9059a
Darshan-upadhyay1110
force-pushed
the
private/darshan/fix-select-row-icon
branch
from
7ad47cd
to
ab0ca93
Compare
eszkadev
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan-upadhyay1110 darshan.upadhyay@collabora.com
Change-Id: Ifa1e2e5397e48d33ede8a6081808cd0051d9059a