Sometimes we only request two rows of tiles in writer on an initial load #7760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolanm/resize_after_initial_tile_request
branch
7 times, most recently
from
c754284
to
e6508eb
Compare
Sometimes we only request and only get two rows of tiles in writer on an initial load. Most frequently I see this with a non-debug online server via nextcloud of the default "Welcome to Nextcloud" docx in firefox in the 2nd or 3rd tab of opening the same document. While the page doesn't visually resize there is a resize delivered after the initial request of tiles. clientvisiblearea x=-8160 y=0 width=28785 height=1575 splitx=0 splity=0 Socket.js:272:10 clientzoom tilepixelwidth=256 tilepixelheight=256 tiletwipwidth=1920 tiletwipheight=1920 Socket.js:272:10 tilecombine nviewid=0 part=0 width=256 height=256 tileposx=0,1920,3840,5760,7680,9600,11520 tileposy=0,0,0,0,0,0,0 oldwid=0,0,0,0,0,0,0 tilewidth=1920 tileheight=1920 Socket.js:272:10 ... tile: nviewid=1001 part=0 width=256 height=256 tileposx=0 tileposy=0 tilewidth=1920 tileheight=1920 oldwid=1 wid=72 ver=92 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=1920 tileposy=0 tilewidth=1920 tileheight=1920 oldwid=1 wid=73 ver=93 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=3840 tileposy=0 tilewidth=1920 tileheight=1920 oldwid=1 wid=74 ver=94 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=5760 tileposy=0 tilewidth=1920 tileheight=1920 oldwid=1 wid=75 ver=95 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=7680 tileposy=0 tilewidth=1920 tileheight=1920 oldwid=1 wid=76 ver=96 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=9600 tileposy=0 tilewidth=1920 tileheight=1920 oldwid=1 wid=77 ver=97 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=11520 tileposy=0 tilewidth=1920 tileheight=1920 oldwid=1 wid=78 ver=98 Socket.js:272:10 ... tileprocessed tile=0:0:0:0:1920:1920:1001,0:0:1920:0:1920:1920:1001,0:0:3840:0:1920:1920:1001,0:0:5760:0:1920:1920:1001,0:0:7680:0:1920:1920:1001,0:0:9600:0:1920:1920:1001,0:0:11520:0:1920:1920:1001 Socket.js:272:10 ... DEBUG: sizeincreased CanvasTileLayer.js:5702:11 ... tilecombine nviewid=0 part=0 width=256 height=256 tileposx=0,1920,3840,5760,7680,9600,11520 tileposy=1920,1920,1920,1920,1920,1920,1920 oldwid=0,0,0,0,0,0,0 tilewidth=1920 tileheight=1920 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=0 tileposy=1920 tilewidth=1920 tileheight=1920 oldwid=1 wid=71 ver=99 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=1920 tileposy=1920 tilewidth=1920 tileheight=1920 oldwid=1 wid=79 ver=100 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=3840 tileposy=1920 tilewidth=1920 tileheight=1920 oldwid=1 wid=80 ver=101 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=5760 tileposy=1920 tilewidth=1920 tileheight=1920 oldwid=1 wid=81 ver=102 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=7680 tileposy=1920 tilewidth=1920 tileheight=1920 oldwid=1 wid=82 ver=103 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=9600 tileposy=1920 tilewidth=1920 tileheight=1920 oldwid=1 wid=83 ver=104 Socket.js:272:10 tile: nviewid=1001 part=0 width=256 height=256 tileposx=11520 tileposy=1920 tilewidth=1920 tileheight=1920 oldwid=1 wid=84 ver=105 Socket.js:272:10 tileprocessed tile=0:0:0:1920:1920:1920:1001,0:0:1920:1920:1920:1920:1001,0:0:3840:1920:1920:1920:1001,0:0:5760:1920:1920:1920:1001,0:0:7680:1920:1920:1920:1001,0:0:9600:1920:1920:1920:1001,0:0:11520:1920:1920:1920:1001 Socket.js:272:10 ... clientvisiblearea x=-8160 y=0 width=28785 height=12075 splitx=0 splity=0 Socket.js:272:10 ... ...no tile requests... Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Id263adbbd98ad0a7c6143d241d0d91e1c28eaac5
caolanm
force-pushed
the
private/caolanm/resize_after_initial_tile_request
branch
from
e6508eb
to
0eda6ad
Compare
|
This one I see in normal use, not just with wasm. This one is more common with firefox I think. And I typically see it on the welcome to nextcloud default document. |
|
Had this again today with (non-debug) online ba536c3 and core 2e57d87 Captured the deferred log from protocol dumping: example.log What I see as unusual vs the working case is the clientvisiblearea lines |
|
And I managed to capture a log with this patch applied where we still have that initial: 1702479723439.OUTGOING.clientvisiblearea x=-8160 y=0 width=28785 height=1575 splitx=0 splity=0 |
eszkadev
approved these changes
Dec 14, 2023
caolanm
deleted the
private/caolanm/resize_after_initial_tile_request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we only request and only get two rows of tiles in writer on an initial load. Most frequently I see this with a non-debug online server via nextcloud of the default "Welcome to Nextcloud" docx in firefox in the 2nd or 3rd tab of opening the same document. While the page doesn't visually resize there is a resize delivered after the initial request of tiles.
Change-Id: Id263adbbd98ad0a7c6143d241d0d91e1c28eaac5
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay