fix: tiles not updated after reconnection

[Rash419]

from idle

The following scenario was affected:

• user A and B both goes idle
• user B starts typing
• user A reconnects, all tiles updated by user B were not getting reflected for user A

Mismatch of canonical ids was causing the issue. On reconnection, tilecombine messages were sent before uno:ChangeTheme can update the canonical id on server side, therefore the received tile cache from server were from old canonical id(

online/wsd/ClientSession.cpp

Line 1379 in 4a8974d

TileCombined tileCombined = TileCombined::parse(tokens);

).

By reseting the previousTheme on connection we make sure there after canonicalidchange we invalidate all the tiles

Change-Id: I874bfe0bd71d176bacf0c7aa768e49613535ebd5

• Resolves: #
• Target version: master

Summary

TODO

• ...

Checklist

• Code is properly formatted
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[caolanm]

If _resetCanonicalIdStatus sets this._canonicalIdInitialized to false I then see that we have:

if (!this._canonicalIdInitialized) {
this._canonicalIdInitialized = true;
this._update();
} else if (viewRenderedState !== this._map.uiManager.previousTheme) {
this._requestNewTiles();
this._invalidateAllPreviews();
this.redraw();
}

inside else if (textMsg.startsWith('canonicalidchange:'))

does that mean we get two canonicalidchange messages on a reconnect?, one setting this._canonicalIdInitialized back to true, and then a second one which triggers the else this._requestNewTiles ... ?

[Rash419]

Yes we get two canonicalidchange message when we load/reconnect

[Rash419]

This might be interesting
#7324

[caolanm]

Yeah, so debugged a bit more and I see that this works and isn't harmful.

I think there's an underlying oddness a viewid 1000 which I think is the reason we get stale tiles back and I'll have a look at a later follow up on that thought.