Handle LOK_CALLBACK_TOOLTIP in wsd #7897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on https://gerrit.libreoffice.org/c/core/+/161302 (and its backport to 23.05). |
mikekaganski
force-pushed
the
private/mk/redline_tooltips
branch
3 times, most recently
from
52265fd
to
9e3a800
Compare
Send "tooltip: <payload>" to client for this callback type. Client-side handling should be implemented separately. Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com> Change-Id: I2d1a07dd36fa20a4b5ff785da788356e0f41d62f
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com> Change-Id: Ibc182d026f2504f7c5bedbbf972f38e4a9ba5db9
mikekaganski
force-pushed
the
private/mk/redline_tooltips
branch
from
9e3a800
to
163749f
Compare
Ashod
approved these changes
Jan 16, 2024
| @@ -3209,6 +3209,11 @@ void ChildSession::loKitCallback(const int type, const std::string& payload) | |||
| sendTextFrame("corelog: " + payload); | |||
| break; | |||
| } | |||
| case LOK_CALLBACK_TOOLTIP: | |||
| { | |||
| sendTextFrame("tooltip: " + payload); | |||
There was a problem hiding this comment.
Might need to add "tooltip:" in HTTPWSTest::testInactiveClient(), in case it is generated by a test document.
There was a problem hiding this comment.
Thank you!
Let me merge this, and then I will try to create a follow-up implementing your suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send "tooltip: " to client for this callback type.
Client-side handling should be implemented separately.
Signed-off-by: Mike Kaganski mike.kaganski@collabora.com
Change-Id: I2d1a07dd36fa20a4b5ff785da788356e0f41d62f