init document theme during load #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
like we do for the spelling setting, so we have the document in the desired state early before any rendering, dropping the early full document invalidations during initial setup Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I6b762c95fd4c00c7da04cf89f7bbeef4bc57375d
caolanm
force-pushed
the
private/caolanm/init_theme_early
branch
from
16f8e06
to
8d7a041
Compare
|
This is in relation to flicker seen on longer writer documents. It looks a good idea to have document in the desired theme from the start, which is something we do already for for spelling mode, and init from the users settings. This needs https://gerrit.libreoffice.org/c/core/+/163650 alongside it. If this passes muster, the follow up suggestion is the pairing of #8329 and https://gerrit.libreoffice.org/c/core/+/163666 to let online know the viewRenderStart of the just constructed documents so we can elide unnecessary "canonicalidchange" messages that cause browser-side to re-request tiles it already asked for. |
mmeeks
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like we do for the spelling setting, so we have the document in the desired state early before any rendering, dropping the early full document invalidations during initial setup
requires https://gerrit.libreoffice.org/c/core/+/163650 in the code to be useful
Change-Id: I6b762c95fd4c00c7da04cf89f7bbeef4bc57375d
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay