fix: data loss when shutting down while using typer #8554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rash419
force-pushed
the
fix-data-loss-on-shutdown
branch
from
898199b
to
97620ce
Compare
Rash419
changed the title
Rash419
force-pushed
the
fix-data-loss-on-shutdown
branch
from
97620ce
to
fce351b
Compare
mmeeks
approved these changes
Mar 18, 2024
Rash419
force-pushed
the
fix-data-loss-on-shutdown
branch
from
fce351b
to
e4f7f77
Compare
|
Backport to co-23.05 branch: #8558 |
- Docbroker only uploads the document when the document is already saved and there are no further modifications. - But when using typer once dockerbroker saves the document and tries to upload there are already new changes to the document. Therefore, docbroker keeps on saving this new changes and keeps on skiping the upload as there are new changes to the document; until it times out Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com> Change-Id: I427d37a6228299006530daddebdf4365af63588b
Rash419
force-pushed
the
fix-data-loss-on-shutdown
branch
from
e4f7f77
to
9df7799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I427d37a6228299006530daddebdf4365af63588b
Checklist
make checkmake runand manually verified that everything looks okay