New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: change table layout in toolbar #8587
Accessibility: change table layout in toolbar #8587
Commits on Apr 30, 2024
-
Change table layout to CSS base table structure
- For the editor in the home view, a layout table is used, and it includes the use of IDs. This can potentially lead to issues with the interpretation of content by assistive technologies - Layout tables are meant to structure the layout of a page and should not contain structural markup like th , caption , summary , headers , or id. Solution: - replace `td` and 'table' tag with `div` - make some changes on css to be consistent with our prev design Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I136cd8d51b2e5035c6ef4292f759f49519e5bd61
Configuration menu - View commit details
-
Copy full SHA for e892687 - Browse repository at this point
Copy the full SHA e892687View commit details -
Adjust table elements for mobile view.
- we changed table structure of `toolbar-wrapper` with `div` - so we also need to consider mobile view - made some neccessary changes for mobileview because of structure change in cool.html.m4 ('toolbar-wrapper') Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I91cd2c3ffbb0d625a78852398f6773136e9a7f6b
Configuration menu - View commit details
-
Copy full SHA for 0a24589 - Browse repository at this point
Copy the full SHA 0a24589View commit details -
Mobile: remove legacy hamburger (opened state) rules (css refactor)
No need to specifically set width and height for .menuwizard-opened state. Best to set only one time those dimensions and just inherit from #toolbar-hamburger no matter the additional css class Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I51eafc6c9b05b843d800b40a990aefd912e463f8
Configuration menu - View commit details
-
Copy full SHA for b4d08ae - Browse repository at this point
Copy the full SHA b4d08aeView commit details -
Mobile: Hamburger and back btn: Fix height after table to div
With "Change table layout to CSS base table structure" and "Adjust table elements for mobile view." changes we now have more divs instead of table elements but with that the hamburger menu is now mislaigned - Fix height - To do: ideally we would make both hamburger menu and the button at its side rendered with the exact same structure which is not the case. And ultimately remove height and just have it flex stretch etc Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Id9365df82f1caff132dde41760a06689ec1145d1
Configuration menu - View commit details
-
Copy full SHA for 5629c06 - Browse repository at this point
Copy the full SHA 5629c06View commit details -
Fix calc-mobile top toolbar and formula bar which are broken
Pedro : This changes from flex to grid (so we can have multiple columns and 2 rows) Darshan: - adding one more div and wrap all child of toolbar-wrapper execpt 'formulabr' will work here - i have tested the css grid approch it is breaking the mobile UI in Calc - here i have changed a bit in html and twiked css which covers all cases Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Ia50fda95e2bef57d707bb4be1dd34e2ec083bfc5
Configuration menu - View commit details
-
Copy full SHA for 133addb - Browse repository at this point
Copy the full SHA 133addbView commit details -
Fix toolbar up section after w2ui rework
To make consistent all toolbar element height with prev version where we were using w2Ui lib - i have added height to table-row element same as we had in prev version - remove fix height for toolbar-up which is not needed now - this fix height will effect the bg-color in toolbar-up section Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I7b307a6a72968ed81fe2eb8663c430f11e3b3ced
Configuration menu - View commit details
-
Copy full SHA for e96e22d - Browse repository at this point
Copy the full SHA e96e22dView commit details