Accessibility: change table layout in toolbar #8587
Merged
Commits on Apr 30, 2024
-
Change table layout to CSS base table structure
- For the editor in the home view, a layout table is used, and it includes the use of IDs. This can potentially lead to issues with the interpretation of content by assistive technologies - Layout tables are meant to structure the layout of a page and should not contain structural markup like th , caption , summary , headers , or id. Solution: - replace `td` and 'table' tag with `div` - make some changes on css to be consistent with our prev design Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I136cd8d51b2e5035c6ef4292f759f49519e5bd61
-
Adjust table elements for mobile view.
- we changed table structure of `toolbar-wrapper` with `div` - so we also need to consider mobile view - made some neccessary changes for mobileview because of structure change in cool.html.m4 ('toolbar-wrapper') Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I91cd2c3ffbb0d625a78852398f6773136e9a7f6b -
Mobile: remove legacy hamburger (opened state) rules (css refactor)
No need to specifically set width and height for .menuwizard-opened state. Best to set only one time those dimensions and just inherit from #toolbar-hamburger no matter the additional css class Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I51eafc6c9b05b843d800b40a990aefd912e463f8
-
Mobile: Hamburger and back btn: Fix height after table to div
With "Change table layout to CSS base table structure" and "Adjust table elements for mobile view." changes we now have more divs instead of table elements but with that the hamburger menu is now mislaigned - Fix height - To do: ideally we would make both hamburger menu and the button at its side rendered with the exact same structure which is not the case. And ultimately remove height and just have it flex stretch etc Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Id9365df82f1caff132dde41760a06689ec1145d1
-
Fix calc-mobile top toolbar and formula bar which are broken
Pedro : This changes from flex to grid (so we can have multiple columns and 2 rows) Darshan: - adding one more div and wrap all child of toolbar-wrapper execpt 'formulabr' will work here - i have tested the css grid approch it is breaking the mobile UI in Calc - here i have changed a bit in html and twiked css which covers all cases Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Ia50fda95e2bef57d707bb4be1dd34e2ec083bfc5 -
Fix toolbar up section after w2ui rework
To make consistent all toolbar element height with prev version where we were using w2Ui lib - i have added height to table-row element same as we had in prev version - remove fix height for toolbar-up which is not needed now - this fix height will effect the bg-color in toolbar-up section Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I7b307a6a72968ed81fe2eb8663c430f11e3b3ced
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.