Fix failing test mobile/calc/spellchecking_spec.js #8588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test failed because of a change in .leaflet-marker-icon Rewrite openContextMenu and remove uses of .leaflet-marker-icon Signed-off-by: Neil Guertin <neil.guertin@collabora.com> Change-Id: Iecfacdd192ea723001ed56e6c9f0c32645a6af2c
6 tasks
gokaysatir
approved these changes
Mar 21, 2024
mcecchetti
approved these changes
Mar 21, 2024
neilguertincollabora
merged commit 5568cee
into
CollaboraOnline:distro/collabora/co-23.05
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failed because of a change in .leaflet-marker-icon
Rewrite openContextMenu and remove uses of .leaflet-marker-icon
23.05 core change that caused the failure: https://gerrit.libreoffice.org/c/core/+/164701
24.04 pull request: #8589
Change-Id: Iecfacdd192ea723001ed56e6c9f0c32645a6af2c
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay