Fix permanent tooltips on dialogs #8594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we can wait until the CI passes to review |
|
hmmm... I am seeing no different before and after this patch :( |
|
@lpranam It would be niceto see a screen record. It works on my side. Maybe you find another use case from drag on angle widget |
|
please rebase to pass CI |
Position and Size dialog of the shape has a rotation angle widget in rotation tab. User can drag move instead only one click on the rotation angle widget. It causes a permanent tooltip on document. So It is better to handle mousedown instead click to close tooltip. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: Idbea0bb8a56568a92f3f4d4c9ee6df1da01b7c24
GulsahKose
force-pushed
the
drawingareatooltip
branch
from
d95eb94
to
3a490cb
Compare
lpranam
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Position and Size dialog of the shape has a rotation angle widget in rotation tab. User can drag move instead only one click on the rotation angle widget. It causes a permanent tooltip on document. So It is better to handle mousedown instead click to close tooltip.
Change-Id: Idbea0bb8a56568a92f3f4d4c9ee6df1da01b7c24
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay