remove-w2ui #11: Mobile top bar #8673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eszkadev
commented
Mar 31, 2024
eszkadev
commented
- converts mobile top bar to JSDialogs
eszkadev
force-pushed
the
private/eszkadev/remove-w2ui-11
branch
2 times, most recently
from
c81de70
to
3fcdffc
Compare
- but still use class for css rules - after rework in styling to use attribute we can drop that Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I568eedf45440f6636c31430cb98adcfdeab6aa4e
- use dispatcher to invoke commands - TODO: checked state for buttons + cypress check Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I652a163ea0c831b47ce7725ffd0f9f190a98d9bf
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Id8fd8e67c80eab7f48d1c519ecddb3d8dfd16062
- it failed due to click on disabled button - make waiting for idle click be aware of that - add small waits after doing table changes to allow updates to be applied Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: If19352923aeca4c18024f3a2ffcc3731a8aff96f
- wait for enabled state - then click internal button Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I7663deb668de2e98b007fbace60386a4a7157058
gokaysatir
force-pushed
the
private/eszkadev/remove-w2ui-11
branch
from
3888489
to
ab0bd32
Compare
|
Rebased to resolve conflict. |
|
Calc: Other than this, everything seems to work. Thanks :) This issue is not a blocker and we can solve it with a one line fix i think. I will merge if it passes the CI. |
gokaysatir
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.