permission: Don't show the edit button if read-only #8693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfiguiere
changed the title
codewithvk
reviewed
Apr 4, 2024
|
@hfiguiere |
I saw it yesterday and it's not related. |
|
I think it might break with mobile. |
hfiguiere
force-pushed
the
private/hub/issue-8686
branch
from
6fecf3d
to
559a70f
Compare
Updated the PR |
caolanm
approved these changes
Apr 4, 2024
hfiguiere
force-pushed
the
private/hub/issue-8686
branch
from
559a70f
to
c305027
Compare
hfiguiere
force-pushed
the
private/hub/issue-8686
branch
from
c305027
to
503c634
Compare
|
The same error occur on master, locally. |
hfiguiere
force-pushed
the
private/hub/issue-8686
branch
from
503c634
to
9101b93
Compare
|
caolanm
force-pushed
the
private/hub/issue-8686
branch
from
9101b93
to
2f4c018
Compare
If wopi.UserCanWrite tells us we can't write the file no reason to show the edit button that would do nothing anyway. Fix #8686 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I4f6d1f8d8be520e422e260f2e532cb86541e8d0f
hfiguiere
force-pushed
the
private/hub/issue-8686
branch
from
2f4c018
to
9bd3dcf
Compare
|
passes ci now at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If wopi.UserCanWrite tells us we can't write the file no reason to show the edit button that would do nothing anyway.
Fix #8686
Change-Id: I4f6d1f8d8be520e422e260f2e532cb86541e8d0f
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay