Prevent opening multiple tooltips on drawing area widgets #8802
Conversation
GulsahKose
force-pushed
the
prevent-multiple-tooltip
branch
from
119a186
to
eff6eee
Compare
|
Problematic cypress test passes locally: I've triggered twice on CI but still failing. |
|
please rebase and force-push, there were some changes with core update for autofilter, maybe patch uses old version |
GulsahKose
force-pushed
the
prevent-multiple-tooltip
branch
from
eff6eee
to
a59d9a0
Compare
GulsahKose
force-pushed
the
prevent-multiple-tooltip
branch
from
a59d9a0
to
11f463e
Compare
GulsahKose
force-pushed
the
prevent-multiple-tooltip
branch
from
11f463e
to
7567840
Compare
| this._tooltip.tooltip('close'); | ||
| this._tooltip = undefined; | ||
| } | ||
| else { |
There was a problem hiding this comment.
it was ok before. I meant other else block: line 1720
There was a problem hiding this comment.
also do we need to do this._tooltip.tooltip() before close?
There was a problem hiding this comment.
Szymon we have to initialize with this._tooltip.tooltip(). Without code doesn't work and throws an error message to debugger console.
It would be nice handle mobile version in separate patch because I don't know much about mobile side. It can take some time to test on mobile.
There was a problem hiding this comment.
ok, then please do the less blinking version as you had. Sorry for the noise.
There was a problem hiding this comment.
The latest commit is combined version of your and mine ideas. It is the best version now. It's ready to test if all tests pass.
We see multiple tooltip problem on drawing area widgets.
Example case:
Add basic shape into a writer document
Right click on shape and open Position and Size dialog
Select the Rotation tab
Hold the rotation angle widget and drag around itself
When you inspect the "Rotation Angle" tooltip, count may be 600
We expect only 1.
So we prevent to show another tooltip if we have already one.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I2f548f8c7afce8095e83a6faa3722e164f990210
GulsahKose
force-pushed
the
prevent-multiple-tooltip
branch
from
7567840
to
a20520b
Compare
We see multiple tooltip problem on drawing area widgets. Example case:
Add basic shape into a writer document
Right click on shape and open Position and Size dialog
Select the Rotation tab
Hold the rotation angle widget and drag around itself
When you inspect the "Rotation Angle" tooltip, count may be 600 We expect only 1.
So we prevent to show another tooltip if we have already one.
Change-Id: I2f548f8c7afce8095e83a6faa3722e164f990210
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay