-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cool.html: append WOPISrc parameter to all JS, CSS & SVG loads #9034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me - thanks Rash =) Did you check we clobber every URL by checking in the browser Network tab as things load ? =)
90ac2a1
to
d60750c
Compare
@mmeeks I did. Do icons url also needs to be appended with WOPISrc ? |
Re: icons - yes, all URLs should have that. |
d60750c
to
f2b28d3
Compare
OK, done |
f2b28d3
to
63d08d3
Compare
63d08d3
to
24b79a5
Compare
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com> Change-Id: I1dd3902403a93914a8ad03b24bed5524a59e5aca
24b79a5
to
233db63
Compare
- use keyboard shortcut to insert comment Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com> Change-Id: Ifa3dfd392d3ec6e62b896d34e19b1e9f5854d3c8
0b6ad10
to
f390481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So - I think we should abandon this for now - I suspect this will break browser caching; and that we should come up with a better approach & design here.
Also a duplicate pull request it seems; lets abandon this one for now. |
Change-Id: I1dd3902403a93914a8ad03b24bed5524a59e5aca