Status bar: Fix MenuButtons being generated always with image #9057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: it seems it fails on unit test but it seems unrelated (I will probably re-try it in the CI). Locally cypress tests pass . |
gokaysatir
approved these changes
May 15, 2024
pedropintosilva
force-pushed
the
private/pedro/StateTableCellMenu-no-image
branch
from
f9642f7
to
572ab12
Compare
Before this commit menu buttons were always generated with img even if it's not applicable. Example, the StateTableCellMenu (located in Calc status bar that allows setting a state according to the function chosen in the submenu): This text-only menu was generated with img and thus throwing a 404 error in the console. - Allow any unoToolButton to be set without image via option - Add image: false option when setting StateTableCellMenu in the statusbar Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I3fc3b5954f80229835526819b9b80d2a650bd922
pedropintosilva
force-pushed
the
private/pedro/StateTableCellMenu-no-image
branch
from
572ab12
to
a5ae715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit menu buttons were always generated with img even if
it's not applicable. Example, the StateTableCellMenu (located in Calc
status bar that allows setting a state according to the function
chosen in the submenu): This text-only menu was generated with img
and thus throwing a 404 error in the console.
statusbar
Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com
Change-Id: I3fc3b5954f80229835526819b9b80d2a650bd922