Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private/pedro/status bar fixes #9091

Merged
merged 2 commits into from
May 20, 2024
Merged

private/pedro/status bar fixes #9091

merged 2 commits into from
May 20, 2024

Conversation

pedropintosilva
Copy link
Contributor

  • Toolbar-down (status bar): Fix hover status
  • Toolbar-down (status bar): Don't over style disable status

@pedropintosilva
Toolbar-down (status bar): Fix hover status
d11b51c 
For all status bar buttons
- Fix missing pointer
- Also, at leat for now, don't add border and don't add different
background. This is a status bar and adding those contributes to the
overall bulkiness. In the future we could perhaps remove the vertical
padding of the status bar and introduce back the background on
over (and remove the border radius). This would make the status bar
slimmer and slicker (so maybe we can turn its visibility on by default)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2b01d1d6c35ff2b3f487de0417170398d587a565
@pedropintosilva
Toolbar-down (status bar): Don't over style disable status
5680972 
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2907f25f63c05b9b59deca19f1d883e27e9ebeb
@pedropintosilva
Copy link
Contributor Author

pedropintosilva commented May 17, 2024 •
edited

This does not affect functionality and also doesn't affect positioning or visibility so if needed we can just skip cypress test.

@mmeeks mmeeks requested a review from gokaysatir May 18, 2024 11:51
gokaysatir
gokaysatir approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@gokaysatir gokaysatir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pedropintosilva :)

@pedropintosilva pedropintosilva merged commit 5ec388e into master May 20, 2024
14 checks passed
@pedropintosilva pedropintosilva deleted the private/pedro/status-bar-fixes branch May 20, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gokaysatir gokaysatir gokaysatir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Collabora Online
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pedropintosilva @gokaysatir