Pre v0.0.1.0 Improvements and Changes #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit,
HttpClientTool
is introduced to replaceDownloadTool
that is still using old deprecatedWebRequest
in .NET Framework with newHttpClient
in .NET CoreLink:
https://docs.microsoft.com/en-us/dotnet/core/compatibility/networking/6.0/webrequest-deprecated
Downloading the file in high bandwidth is much improved with
HttpClient
behind v0.0.0.1 that is still usingWebRequest
And here's the benchmark result while downloading the Daily Update Files for both Global and SEA version:
Also this commit bring some other improvements and changes including:
Logger
class is now bring together withILogger
Interface. This Interface will be used for cross-method log output.HttpClient
instead ofWebRequest
for downloading.ReadRemoteStream()
) onHttpClientTool
class for better code writing while implement another downloading methods.DummyLogger
for hiding log output while Console is disabled.