Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails #24

Closed
shawngraham opened this issue Nov 10, 2021 · 7 comments
Closed

build fails #24

shawngraham opened this issue Nov 10, 2021 · 7 comments

Comments

@shawngraham
Copy link

Very interested to give this a whirl; love the idea! Great work.

Can't get it to build though. Followed the 'brief overview' directions, also consulting the docs, to use the template. Changed the config with my own site settings to use with gh pages, used the demo metadata template and added one line of info; the build fails every time. The error message from github is not useful; just says page failed, so I'm a bit baffled. I am not very familiar with troubleshooting jekyll.

my repo: https://github.com/shawngraham/test-collectionbuilder

my metadata file: https://github.com/shawngraham/test-collectionbuilder/blob/main/_data/demo-sg.csv

my config:

# site domain, full URL to the production location of your collection
url: https://shawngraham.github.io
# path to location on the domain if necessary e.g. /digital/hjccc
baseurl: /test-collectionbuilder
# location of code, the full url to your github repository
source-code: https://github.com/shawngraham/test-collectionbuilder

followed eventually with:

# Use the filename of your CSV **without** the ".csv" extension! E.g. _data/demo-metadata.csv --> "demo-metadata"
metadata: demo-sg
@evanwill
Copy link
Contributor

@shawngraham thanks for giving it a whirl!
Your demo repository and metadata look correct, and it will build locally using Jekyll--however collectionbuilder-csv can't be built using standard GitHub Pages build (it uses plugins and a more up-to-date version of Jekyll)--so the build just fails.

You can use collectionbuilder-gh template with standard GH pages, or you can set up a GitHub action to build your CSV version.

Let us know how it goes!

@dcnb
Copy link
Contributor

dcnb commented Nov 10, 2021 via email

@dcnb
Copy link
Contributor

dcnb commented Nov 10, 2021 via email

@shawngraham
Copy link
Author

ah, gotcha! thanks @evanwill @dcnb I'll give both of those workflows a try.

@evanwill
Copy link
Contributor

ha ha, @dcnb still not sure how logging into another service, clicking a bunch of buttons over there and linking things up is easier than adding a single YAML file to your repository? 😉 😉

@shawngraham
Copy link
Author

ok, an update - i tried both the workflow, and the Render thingy.

Both were quite easy. However, with the workflow, the workflow would run, but the site would still not deploy. With render, it deployed, but was broken. The log file for Render showed an interesting error:

Error cb_helpers: Item for featured image with objectid 'demo_001' not found in configured metadata 'demo-sg'. Please check 'featured-image' in '_data/theme.yml'

In my metadata file, I had deleted a few of the items. So, I changed the featured image in the _data/theme.yml to the image that I had added to the metadata (demo_008) and lo! and behold! the github action worked.

So there we go. One thing - since I added the action, and the workflow was deploying to a new branch, I had to update the pages settings to load from that branch. Anyway, very cool!

@evanwill
Copy link
Contributor

Oh okay thanks for the update @shawngraham that's helpful-- that is weird/frustrating that the CB warning message is actually causing the GitHub Action and Render to not build it! That is intended to be a helper when you are working locally, and it doesn't interrupt the build, so not sure why the Action is taking those messages as an error and exiting. I will have to look into that...

maehr added a commit to maehr/collectionbuilder-csv that referenced this issue Mar 1, 2024
* feat: localization logic for datatables

* feat: translations added WIP

* feat: lang key added to _config.yml

* feat: added translations with complex html fields

* feat: more translations

* feat: more translations

* feat: merge hell fix

* feat: more translations

* fix: more translations

* fix: more translations

* fix: improved translations

* fix: Update _layouts/timeline.html

Co-authored-by: Nico Görlich <73133626+koilebeit@users.noreply.github.com>

* fix: search button placeholder translated

* fix: results found translation added

* fix: single tranlsation fixed

* fix: search page translations fixed

* fix: merge issues resolved

* feat: de enabled

* fix: possible fix for CollectionBuilder#54

* feat: 404 translated

---------

Co-authored-by: Nico Görlich <73133626+koilebeit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants