feat: add sum, count, all, any and none field operations
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasfara
force-pushed
the
feat/number-field-ops
branch
from
7775a7b
to
aa6ebcf
Compare
nicolasfara
force-pushed
the
feat/number-field-ops
branch
from
aa6ebcf
to
de1b209
Compare
DanySK
force-pushed
the
feat/number-field-ops
branch
2 times, most recently
from
2108c1f
to
24086b2
Compare
DanySK
reviewed
May 15, 2024
dsl/src/commonMain/kotlin/it/unibo/collektive/field/FieldManipulation.kt
Outdated
Show resolved
Hide resolved
DanySK
force-pushed
the
feat/number-field-ops
branch
4 times, most recently
from
d032a37
to
8936cd2
Compare
DanySK
requested changes
May 19, 2024
dsl/src/commonMain/kotlin/it/unibo/collektive/field/FieldManipulation.kt
Outdated
Show resolved
Hide resolved
dsl/src/commonMain/kotlin/it/unibo/collektive/field/FieldManipulation.kt
Outdated
Show resolved
Hide resolved
dsl/src/commonMain/kotlin/it/unibo/collektive/field/operations/BooleanField.kt
Outdated
Show resolved
Hide resolved
dsl/src/commonMain/kotlin/it/unibo/collektive/field/operations/BooleanField.kt
Outdated
Show resolved
Hide resolved
dsl/src/commonMain/kotlin/it/unibo/collektive/field/operations/NumberUtils.kt
Outdated
Show resolved
Hide resolved
DanySK
force-pushed
the
feat/number-field-ops
branch
2 times, most recently
from
bc16808
to
a5aba2a
Compare
DanySK
requested changes
May 21, 2024
...carnation-collektive/src/test/resources/it/unibo/collektive/test/load-from-kotlin-inline.yml
Outdated
Show resolved
Hide resolved
dsl/src/commonMain/kotlin/it/unibo/collektive/field/operations/Fields.kt
Outdated
Show resolved
Hide resolved
dsl/src/commonMain/kotlin/it/unibo/collektive/field/operations/Fields.kt
Outdated
Show resolved
Hide resolved
DanySK
force-pushed
the
feat/number-field-ops
branch
3 times, most recently
from
783a49d
to
f4cdd00
Compare
DanySK
force-pushed
the
feat/number-field-ops
branch
5 times, most recently
from
a73bec5
to
4440390
Compare
DanySK
force-pushed
the
feat/number-field-ops
branch
4 times, most recently
from
d7c5046
to
3b63615
Compare
|
@DanySK could you make a second pass on this? |
DanySK
force-pushed
the
feat/number-field-ops
branch
from
10ed8f3
to
194dfea
Compare
DanySK
force-pushed
the
feat/number-field-ops
branch
from
194dfea
to
f6554c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the field manipulation operations requested in #338.
Closes #338