Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: #38 #39

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Feat: #38 #39

merged 2 commits into from
Mar 11, 2024

Conversation

View12138
Copy link
Contributor

No description provided.

@CollinAlpert
Copy link
Owner

Thanks for this, it's a good idea! Can you make sure the tests pass before I review the PR?

@View12138
Copy link
Contributor Author

I'm sure that the PR code can pass the test, because I can't run your test project locally, so I wrote another test project myself to test the code I submitted, and the new code in the issue is generated by my local test project

@View12138
Copy link
Contributor Author

I'd also like to share with you my test scenario, which can be used to get into debug mode using VS's debug test method without having to attach to a process, which I think might be easier to write code and test projects

{
return (modifier, ParameterList(), Block());
}
var fields = typeDeclaration.Members
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be only whitespace changes, please revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already fixed it.

@CollinAlpert
Copy link
Owner

CollinAlpert commented Feb 26, 2024

Please let me know why you can't run the test project locally, this is something I would definitely need to fix.

Keep in mind you need to run the tests while in Release mode so the debugger does not wait for an attached process: https://github.com/CollinAlpert/Lombok.NET?tab=readme-ov-file#building-and-debugging

@View12138
Copy link
Contributor Author

This is my test project

@CollinAlpert
Copy link
Owner

Sorry about the delay, I've had a busy week but will get to this on the weekend the latest.

@CollinAlpert
Copy link
Owner

Looks good! I will look into using Verify for tests in the future.

@CollinAlpert CollinAlpert merged commit 6d1863a into CollinAlpert:master Mar 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants