Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection timeouts cause crash #10

Closed
cyberbit opened this issue Sep 6, 2023 · 3 comments
Closed

Connection timeouts cause crash #10

cyberbit opened this issue Sep 6, 2023 · 3 comments

Comments

@cyberbit
Copy link
Contributor

cyberbit commented Sep 6, 2023

While running satpaper, if the connection experiences a momentary outage (either on client or SLIDER end) while tiles are being collected, the program loop crashes. Here's an excerpt of the log when that occurs:

image

The exact message and segment of code varies depending on what stage of the loop is running. Maybe a gated "retry x times" flag with exponential backoff would be good here? If retrying each tile isn't feasible, then maybe logging the error was caught and waiting for next schedule to retry. I figured failing outright probably isn't intended.

@Colonial-Dev
Copy link
Owner

I think it makes the most sense to just catch/log the error and wait until the next go round. The delay is negligible (sixty seconds, assuming the outage is momentary.)

I figured failing outright probably isn't intended.

Yeeeah, I'm a little too used to "just HCF and let systemd restart the thing."

@cyberbit
Copy link
Contributor Author

cyberbit commented Sep 6, 2023

let systemd restart the thing

Ha, yeah this was my plan for the Docker container regardless. Long live systemd!

Colonial-Dev added a commit that referenced this issue Sep 6, 2023
@Colonial-Dev
Copy link
Owner

(Forgot to trap errors from another request function - sorry if you already built the previous commit!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants