Test

Documentation improvements #92

Triggered via push January 12, 2024 09:33

Coloquinte

pushed aa3b2b7

Status Success

Total duration 5m 6s

Artifacts –

build.yml

on: push

Matrix: Check

Annotations

64 warnings

Check (ubuntu-latest)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Check (ubuntu-latest)

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check (ubuntu-latest)

Check (ubuntu-latest, --no-default-features)

this returns a `Result<_, ()>`: src/static_lut.rs#L359

warning: this returns a `Result<_, ()>` --> src/static_lut.rs:359:5 | 359 | pub fn from_hex_string(s: &str) -> Result<Self, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

the loop variable `i` is only used to index `vars`: src/sop/optim/sat.rs#L425

warning: the loop variable `i` is only used to index `vars` --> src/sop/optim/sat.rs:425:18 | 425 | for i in 1..vars.len() { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 425 | for <item> in vars.iter().skip(1) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~

length comparison to one: src/sop/optim/sat.rs#L423

warning: length comparison to one --> src/sop/optim/sat.rs:423:17 | 423 | assert!(vars.len() >= 1); | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!vars.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

module has the same name as its containing module: src/sop.rs#L10

warning: module has the same name as its containing module --> src/sop.rs:10:1 | 10 | mod sop; | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

unneeded `return` statement: src/sop/ecube.rs#L105

warning: unneeded `return` statement --> src/sop/ecube.rs:105:9 | 105 | return true; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 105 - return true; 105 + true |

unneeded `return` statement: src/sop/ecube.rs#L90

warning: unneeded `return` statement --> src/sop/ecube.rs:90:9 | 90 | return max(self.num_lits(), 1) - 1; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 90 - return max(self.num_lits(), 1) - 1; 90 + max(self.num_lits(), 1) - 1 |

unneeded `return` statement: src/sop/cube.rs#L149

warning: unneeded `return` statement --> src/sop/cube.rs:149:9 | 149 | return true; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 149 - return true; 149 + true |

unneeded `return` statement: src/sop/cube.rs#L119

warning: unneeded `return` statement --> src/sop/cube.rs:119:9 | 119 | return max(self.num_lits(), 1) - 1; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 119 - return max(self.num_lits(), 1) - 1; 119 + max(self.num_lits(), 1) - 1 |

this returns a `Result<_, ()>`: src/lut.rs#L383

warning: this returns a `Result<_, ()>` --> src/lut.rs:383:5 | 383 | pub fn from_hex_string(num_vars: usize, s: &str) -> Result<Self, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default

the loop variable `i` is used to index `res_perm`: src/canonization.rs#L272

warning: the loop variable `i` is used to index `res_perm` --> src/canonization.rs:272:14 | 272 | for i in 0..res_perm.len() { | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 272 | for (i, <item>) in res_perm.iter_mut().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

the variable `ind` is used as a loop counter: src/canonization.rs#L233

warning: the variable `ind` is used as a loop counter --> src/canonization.rs:233:5 | 233 | for swap in all_swaps { | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (ind, swap) in all_swaps.iter().enumerate()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop

the loop variable `i` is used to index `res_perm`: src/canonization.rs#L229

warning: the loop variable `i` is used to index `res_perm` --> src/canonization.rs:229:14 | 229 | for i in 0..res_perm.len() { | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 229 | for (i, <item>) in res_perm.iter_mut().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

the variable `ind` is used as a loop counter: src/canonization.rs#L163

warning: the variable `ind` is used as a loop counter --> src/canonization.rs:163:5 | 163 | for swap in all_swaps { | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (ind, swap) in all_swaps.iter().enumerate()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop = note: `#[warn(clippy::explicit_counter_loop)]` on by default

the loop variable `i` is used to index `all_perms`: src/canonization.rs#L117

warning: the loop variable `i` is used to index `all_perms` --> src/canonization.rs:117:18 | 117 | for i in 0..all_perms.len() { | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator and enumerate() | 117 | for (i, <item>) in all_perms.iter().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Clippy

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Clippy

Check (ubuntu-latest, --features optim-sat)

Bench

Check (macos-latest)

Check (windows-latest)

Check (macos-latest, --no-default-features)

Check (windows-latest, --no-default-features)

Check (ubuntu-latest, --features optim-mip)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Documentation improvements #92

Summary