-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements and fixes - incl. VDB loaders, better FPS checks in Houdini #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-between more primary loaders
Fix code readability with generic Popup class FPS popup now shows what current FPS is and what it will change it to. So it shows current FPS and project FPS. FPS popup Maya "update keys" checkbox actually doing something. :) (Oh my god, that code that was there... lol) FPS popup in Houdini title stating "Maya scene", now shows "Houdini Scene" FPS popup not being positioned correctly in rare cases. Outdated Assets in Scene message in Houdini stating "Maya scene" now shows "Houdini Scene"
- Sort V-Ray VDB before Redshift VDB (more likely to be used)
- This is better than getting None type error on the code running afterwards
- Remove non-working _001 counter - Remove redundant _CON suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes
Loader
Implement VDB for V-ray Loader in Maya - now works correctly!
Implement VDB for Redshift Loader in Maya - now works correctly!
Implement VDB for Arnold Loader in Maya - new.
Implement VDB Loader in Houdini
Implement Set Frame Range actions in Loader in Houdini
Improved Copy File Path / Copy Path sorting so they are less intertwined with other actions in the Loader
Changed Copy File Path / Copy Path icon colors for less clutter.
Improved Loader Maya "Import Model" warning message so it describes that it will import it as unlinked to Avalon pipeline.
Houdini Loaders, simplify loaded name - remove _001 counter that didn't work anyway + remove _CON suffix.
FPS + Outdated Scene Pop-ups
Implement Houdini set asset FPS on "new scene.."
Implement Houdini set asset FPS on launch (so startup scene has correct FPS)
Fix code readability with generic Popup class
Fix FPS popup Maya "update keys" checkbox actually doing something. :) (Oh my god, that code that was there... lol)
Fix FPS popup not being positioned correctly in rare cases.
FPS popup now shows what current FPS is and what it will change it to. So it shows current FPS and project FPS.
FPS popup in Houdini title stating "Maya scene", now shows "Houdini Scene"
Outdated Assets in Scene message in Houdini stating "Maya scene" now shows "Houdini Scene"
Houdini Publishing