Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the user is an administrator, invoices can be deleted #2740

Merged
merged 5 commits into from
Dec 30, 2022
Merged

When the user is an administrator, invoices can be deleted #2740

merged 5 commits into from
Dec 30, 2022

Conversation

belwalshubham
Copy link
Contributor

@belwalshubham belwalshubham commented Dec 29, 2022 •
edited

Targets #2739

Description

Checklist:

  • I have performed a self-review of my own code.

@cypress
Copy link

cypress bot commented Dec 29, 2022 •
edited


Test summary

4 • 0 • 0 • 0 • Flakiness 0

Run details
Project Employee portal
Status Passed
Commit 65d6d67 ℹ️
Started Dec 30, 2022 9:20 AM
Ended Dec 30, 2022 9:21 AM
Duration 00:46 💡
OS Linux Ubuntu - 22.04
Browser Electron 91

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@belwalshubham belwalshubham self-assigned this Dec 29, 2022
@belwalshubham belwalshubham added the status : ready for review Items that are ready for code review label Dec 29, 2022
GauravGusain98
GauravGusain98 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@GauravGusain98 GauravGusain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GauravGusain98
GauravGusain98 requested changes Dec 30, 2022
View reviewed changes
Copy link
Member

@GauravGusain98 GauravGusain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working. Still getting unauthorized error when deleting invoice using admin user.

GauravGusain98
GauravGusain98 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@GauravGusain98 GauravGusain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GauravGusain98 GauravGusain98 merged commit cbd3a6c into master Dec 30, 2022
@GauravGusain98 GauravGusain98 deleted the feature/delete-invoice-information branch December 30, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GauravGusain98 GauravGusain98 GauravGusain98 approved these changes

Assignees

@belwalshubham belwalshubham

Labels
status : ready for review Items that are ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@belwalshubham @GauravGusain98