Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] URLs with characters '?' and '=' not encoded properly in sidebar search results. #3556

Closed
zammitjohn opened this issue Apr 1, 2021 · 6 comments · Fixed by #3557
Closed

[BUG] URLs with characters '?' and '=' not encoded properly in sidebar search results. #3556

zammitjohn opened this issue Apr 1, 2021 · 6 comments · Fixed by #3557
Assignees
@danny007in
Labels
state:in-progress type:bug version:3.2.x
Projects
v3.2.0
Milestone
v3.2.0

Comments

@zammitjohn
Copy link

Describe the bug
URLs with characters '?' and '=' not text encoded properly in sidebar search results.
? -> %3F
= -> %3D

To Reproduce
Steps to reproduce the behavior:

  1. Add element to sidebar element with 'href' containing a '?' or '='
  2. Search for the element from the sidebar
  3. Click on the result

Environment (please complete the following information):

  • AdminLTE Version: v3.1.0
  • Browser (Version): Chrome (Latest)
@danny007in danny007in self-assigned this Apr 2, 2021
@danny007in
Copy link
Collaborator

add url here ill check

danny007in added a commit to danny007in/AdminLTE that referenced this issue Apr 2, 2021
@danny007in
Fix: sidebar search url issue
96cd3b0 
Fixed ColorlibHQ#3556
@danny007in danny007in mentioned this issue Apr 2, 2021
Merged
@danny007in
Copy link
Collaborator

Fixed in #3557

@danny007in danny007in added this to To do in v3.2.0 via automation Apr 2, 2021
@danny007in danny007in added this to the v3.1.0 milestone Apr 2, 2021
@danny007in danny007in moved this from To do to Done in Branch (Merge/Review required) in v3.2.0 Apr 2, 2021
danny007in added a commit to danny007in/AdminLTE that referenced this issue Apr 2, 2021
@danny007in
Fix: sidebar search url issue
611cbbb 
Fixed ColorlibHQ#3556
@zammitjohn
Copy link
Author

Thanks @danny007in!

v3.2.0 automation moved this from Done in Branch (Merge/Review required) to Done Apr 6, 2021
REJack pushed a commit that referenced this issue Apr 6, 2021
@danny007in
Fix: sidebar search url issue (#3557)
c434c98 
Fixed #3556
@danny007in danny007in mentioned this issue Apr 19, 2021
Closed
@danny007in danny007in modified the milestones: v3.1.0, v3.2.0 Apr 27, 2021
@danny007in danny007in mentioned this issue May 9, 2021
Closed
@muhanadali100
Copy link

not working with me and i use the last update

@danny007in
Copy link
Collaborator

not working with me and i use the last update

did u compiled

@muhanadali100
Copy link

not working with me and i use the last update

did u compiled

yep i complied and not working

@danny007in danny007in mentioned this issue May 12, 2021
Closed
@REJack REJack mentioned this issue Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danny007in danny007in

Labels
state:in-progress type:bug version:3.2.x
Projects
No open projects
v3.2.0
  
Done
Milestone
v3.2.0
Development

Successfully merging a pull request may close this issue.

Fix: sidebar search url issue danny007in/AdminLTE
3 participants
@muhanadali100 @danny007in @zammitjohn