You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When installing AdminLTE with Composer, we got all files from the repository. This is not what we really want in a production environment, or even in a development environment, as many files are totally useless because :
we can read the doc and content of pages on github and/or the website of AdminLTE).
these files could be useful for contributors, but using Composer to work on the source code of AdminLTE is not really the good way (and when using a dev version pattern like dev-master, they'll have all files anyway).
Removing the docs/, pages/, .github/ and some files at the root directory, would save around 30 MB of disk space (which represents 30% of the total size). Downloading less bytes is faster for a CI environment, or to deploy to a production or test environment, and save bandwidth for applications that host the package, like Packagist.org.
To Reproduce
Steps to reproduce the behavior:
Install the package with Composer.json
Go into vendor/almasaeed2010/adminlte/
there are some directories that we don't need, as a user of AdminLTE
Expected behavior
We should not have some directories into vendor/almasaeed2010/adminlte/.
I suggest to add these lines into .gitattributes to not have these directories :
Well, you could provide your own zip files with content you want to distribute, by configuring github actions or an other CI tool.
I understand that providing the documentation can be interesting for users, but do they really need all build stuff (so build/, package.json and all dot files)? (I'm not talking about contributors, because contributors should clone the repository).
This problem cannot be truly solved unless adminlte is treated as a pure web project and the composer download method is removed, so that only the dist directory can be retained when pushed to NPM
When installing AdminLTE with Composer, we got all files from the repository. This is not what we really want in a production environment, or even in a development environment, as many files are totally useless because :
dev-master
, they'll have all files anyway).Removing the
docs/
,pages/
,.github/
and some files at the root directory, would save around 30 MB of disk space (which represents 30% of the total size). Downloading less bytes is faster for a CI environment, or to deploy to a production or test environment, and save bandwidth for applications that host the package, like Packagist.org.To Reproduce
Steps to reproduce the behavior:
Expected behavior
We should not have some directories into
vendor/almasaeed2010/adminlte/
.I suggest to add these lines into .gitattributes to not have these directories :
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: