Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall theme #37

Closed
franciscolourenco opened this issue Jul 23, 2017 · 10 comments
Closed

Uninstall theme #37

franciscolourenco opened this issue Jul 23, 2017 · 10 comments

Comments

@franciscolourenco
Copy link

Is there a command to uninstall themes?

@blopker
Copy link
Member

blopker commented Jul 24, 2017

No, there's currently no command to uninstall a theme. However, you can just remove them from the folder.

Go to Preferences > Browse Packages... then open up the Colorsublime - Themes folder. You can remove anything you'd like in there.

Cheers!

@blopker blopker closed this as completed Jul 24, 2017
@franciscolourenco
Copy link
Author

I could also install themes by "just" dragging them to that folder. Please re-open this issue and consider it a feature request instead of a question.

@blopker
Copy link
Member

blopker commented Jul 25, 2017

Yessir!

Pull requests are always welcome :)

@blopker blopker reopened this Jul 25, 2017
@GianlucaGuarini
Copy link
Member

@aristidesfl this feature does not make any sense, if you use colorsublime you will always download all its themes and the colorsublime plugin must always be in sync with our repo there is no way to uninstall a theme. Closing this issue as wontfix

@franciscolourenco
Copy link
Author

That doesn't describe the experience i have with colorsublime. I only have installed a few themes.

@GianlucaGuarini
Copy link
Member

@aristidesfl here we are discussing about a feature of the colorsublime plugin that i think it doesn't make any sense. You will be still able to download and install all the themes manually if you like but the there is no need for the plugin to support themes uninstalling since they will be re downloaded on any sync event

@franciscolourenco
Copy link
Author

franciscolourenco commented Aug 6, 2017

@GianlucaGuarini what you just said makes no sense, at least from my point of view (user). I can see and switch installed themes with Schemr. I can install themes individually by using the action Colorsublime: Install Theme. I should also be able to uninstall them individually with the equivalent, opposite action Colorsublime: Uninstall Theme.

@GianlucaGuarini
Copy link
Member

@aristidesfl I guess Colorsublime: Install Theme should be renamed Colorsublime: Show Themes since it downloads all of them anyways. Probably having two commands like Colorsublime: Fetch Themes and Colorsublime: Switch Theme could be also a better semantic option. @blopker have you better ideas?

@franciscolourenco
Copy link
Author

@GianlucaGuarini they might be downloaded while previewing, but they don't become installed until you press enter. From the point of view of the user, the fact they are downloaded is irrelevant, since they only appear the in list of installed themes, after they have been installed.

@blopker
Copy link
Member

blopker commented Aug 7, 2017

I do agree using install here is a little non-standard since it does two things; refreshes the cache and copies files from it. Although, to the average user it's all the same I guess.

However, since there is an install I suppose users would expect an uninstall even though it's trivial to just remove the file. It's easy enough to implement anyway. I'll make a PR.

@blopker blopker reopened this Aug 7, 2017
blopker pushed a commit that referenced this issue Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants