Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: add phase of the particle-2 convention #40

Merged
merged 10 commits into from
Jan 23, 2023
Merged

DOC: add phase of the particle-2 convention #40

merged 10 commits into from
Jan 23, 2023

Conversation

mmikhasenko
Copy link
Contributor

@mmikhasenko mmikhasenko commented Jan 13, 2023 •
edited by redeboer

Add the phase of the particle-2 convention and a comment in the text.

Closes #39

imageimage

@mmikhasenko
add the phase of the particle-2 convention
3f085b1 
also, a comment in the text.
@redeboer
Copy link
Member

Thanks for spotting!
Yes, the phase is used in the implementation, but indeed not explained. (The text started more as some notes to summarize the main formulas, but then decided to commit them.)

@redeboer redeboer self-assigned this Jan 19, 2023
@redeboer redeboer changed the title Phase of the particle-2 convention DOC: add phase of the particle-2 convention Jan 21, 2023
@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Jan 21, 2023
@redeboer redeboer self-requested a review January 21, 2023 21:11
@redeboer redeboer added this to the 0.1.5 milestone Jan 23, 2023
@redeboer redeboer enabled auto-merge (squash) January 23, 2023 13:46
@redeboer redeboer enabled auto-merge (squash) January 23, 2023 13:53
@redeboer redeboer enabled auto-merge (squash) January 23, 2023 13:55
@redeboer redeboer merged commit cfd03a7 into ComPWA:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redeboer redeboer Awaiting requested review from redeboer

Assignees

@redeboer redeboer

Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Milestone
0.1.5
Development

Successfully merging this pull request may close these issues.

Add phase of the particle-2 convention
2 participants
@mmikhasenko @redeboer