Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix pytest-notebook for demos #49

Merged
merged 8 commits into from
Oct 26, 2021
Merged

ci: fix pytest-notebook for demos #49

merged 8 commits into from
Oct 26, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 28, 2021

@redeboer redeboer added 🐛 Bug Something isn't working 🖱️ DX Improvements to the Developer Experience labels Aug 28, 2021
@redeboer redeboer self-assigned this Aug 28, 2021
@redeboer redeboer force-pushed the fix-pytest branch 3 times, most recently from 34b35c9 to 36a53fb Compare August 30, 2021 19:47
@redeboer redeboer marked this pull request as draft September 17, 2021 14:42
@redeboer redeboer mentioned this pull request Sep 20, 2021
@redeboer redeboer force-pushed the fix-pytest branch 3 times, most recently from 3bcec40 to 779948f Compare September 20, 2021 15:32
@redeboer
Copy link
Member Author

Issue turned out to be caused by jupyter-client, see https://stackoverflow.com/a/67062211/13219025.

Note that the same error could be produced with nbconvert (which makes it clear that the error does not come from pytest):

jupyter nbconvert --to html --execute demo/*.ipynb

From the traceback, it seemed that the solution would be to upgrade nbconvert (would require an upstream upgrade to pytest-notebook), but the problem actually comes from a coroutine (probably in jupyter-client).

At any rate, the issue has been fixed (779948f and 35878a0). Remaining problem remains that analytic continuation now failes. This should be addressed first in ComPWA/tensorwaves#312.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer removed the 🖱️ DX Improvements to the Developer Experience label Oct 26, 2021
@redeboer redeboer marked this pull request as ready for review October 26, 2021 15:24
@redeboer redeboer merged commit 0414170 into main Oct 26, 2021
@redeboer redeboer deleted the fix-pytest branch October 26, 2021 15:25
redeboer added a commit to ComPWA/tensorwaves that referenced this pull request Dec 1, 2021
pytest-notebook does not work well, see e.g.
ComPWA/compwa.github.io#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant