Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching of partial calculations #100

Closed
spflueger opened this issue Jun 26, 2020 · 0 comments · Fixed by #247
Closed

Caching of partial calculations #100

spflueger opened this issue Jun 26, 2020 · 0 comments · Fixed by #247
Assignees
Milestone

Comments

@spflueger
Copy link
Member

spflueger commented Jun 26, 2020

The current Tensorflow code runs relatively slow (about 3x slower than pycompwa), which is related to the fact that tensorwaves is not caching any computations. Even the ones that that stay constant throughout the whole fitting/optimization phase (WignerD functions).

Some flexible and easy to use scheme is necessary to implement local caching.

Update: A lot of things have changed since. Now with the sympy + lambdify, the whole model can be optimized much easier. A separate method was added to the Model interface performance_optimize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants