-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add caching of constant sub expressions in SympyModels #247
Conversation
I'm keeping it like this for now. Not the best user interface, but I suspect we have more issues regarding the Model interface and the gradient as well. So I think this Model interface just does not cut it... |
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 79.71% 81.17% +1.46%
==========================================
Files 13 13
Lines 641 712 +71
Branches 97 119 +22
==========================================
+ Hits 511 578 +67
- Misses 93 96 +3
- Partials 37 38 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
20fa3de
to
3b30a44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I left a few comments. It's a bit obscure why the macos job keeps failing now, looking into it. This is a problem that sporadically happened before, so this has to be tackled anyway. (Still, it's strange that this PR makes the macos job more unstable.)
cc6b313
to
4c63396
Compare
A series of PRs related to the callbacks is coming up that might fix the CI problem seen here. |
Closes #100