Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hints numpy, pandas, and matplotlib #125

Closed
redeboer opened this issue Aug 19, 2020 · 2 comments
Closed

Fix type hints numpy, pandas, and matplotlib #125

redeboer opened this issue Aug 19, 2020 · 2 comments
Labels
🖱️ DX Improvements to the Developer Experience 🔨 Maintenance Maintenance and upkeep improvements

Comments

@redeboer
Copy link
Member

redeboer commented Aug 19, 2020

Type hints for numpy are currently not checked with mypy. This can be done by installing with data-science-types. I have the impression that we use numpy in the wrong way here and there (for instance, numpy.size used here seems to be deprecated), so those issues need to be fixed.

In a follow-up (#131), the shapes of the ndarrays can then be specified in type hints as well.

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Aug 19, 2020
@redeboer redeboer self-assigned this Oct 9, 2020
@redeboer redeboer added Epic Collection of issues 🐛 Bug Something isn't working 🔨 Maintenance Maintenance and upkeep improvements and removed Epic Collection of issues labels Oct 9, 2020
@redeboer
Copy link
Member Author

I've given this data-science-types a try, but there seem to be some serious issues still (the package has only been around since this year). It's a pity, because the current type hints of numpy.ndarray are just ignored by mypy, but I don't see a way around this for now.

Therefore, I'll put this one and #131 in the icebox for now. It seems that typing for nympy is still under development (both by external packages and by numpy itself).

@redeboer redeboer removed their assignment Nov 13, 2020
@redeboer redeboer removed the 🐛 Bug Something isn't working label Mar 24, 2021
@redeboer
Copy link
Member Author

redeboer commented Dec 6, 2021

This issue has become less relevant since #345. Closing it for now.

@redeboer redeboer closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience 🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Development

No branches or pull requests

1 participant