refactor: adapt implementation to AmpForm v0.12.x #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
redeboer
force-pushed
the
ampform-v0.12
branch
from
17b4039
to
189016b
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
force-pushed
the
ampform-v0.12
branch
from
5b2791a
to
9f8a4ab
Compare
Auto-fixes from pre-commit.com hooks. For more information, see https://pre-commit.ci
redeboer
force-pushed
the
ampform-v0.12
branch
from
4ab7797
to
9ae8a2b
Compare
This was referenced Dec 6, 2021
kwargs is unsafe with linters and clogs the code
|
95fa4c5 (#374) indeed seems to fix #345 (comment) 🎉 |
This reverts commit 81779c2.
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the
datamodule implementation so that it can work with AmpForm v0.12.x. Closes ComPWA/ampform#182.Some major changes:
DataSampleare nowstronly, notint. This means that momentum samples have keys"p0","p1", etc. instead of0,1. This is in accordance with theSymbolnames used in AmpForm'sHelicityModel.kinematic_variables.create_function()that creates aPositionalArgumentFunction. This is aFunctionwithout parameters (compareParametrizedFunction). The function and related class is used in theDataTransformerimplementation, which doesn't need parameters.