Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outsource evaluation (doit) of SymPy expressions #280

Closed
redeboer opened this issue Jun 1, 2021 · 0 comments · Fixed by #347
Closed

Outsource evaluation (doit) of SymPy expressions #280

redeboer opened this issue Jun 1, 2021 · 0 comments · Fixed by #347
Assignees
@redeboer
Labels
⚠️ Interface Breaking changes to the API

Comments

@redeboer
Copy link
Member

redeboer commented Jun 1, 2021

Currently, SympyModel always performes a doit() on input expressions, which can take a long time for longer expressions. We should consider giving this reponsibility to the caller.

tensorwaves/src/tensorwaves/model.py

Lines 311 to 313 in f0cbcaa

self.__expression: sp.Expr = expression.doit()
# after .doit() certain symbols like the meson radius can disappear
# hence the parameters have to be shrunk to this space

See also #273
@redeboer redeboer added the ❔ Question Discuss this matter in the team label Jun 1, 2021
@redeboer redeboer self-assigned this Nov 23, 2021
@redeboer redeboer added ⚠️ Interface Breaking changes to the API and removed ❔ Question Discuss this matter in the team labels Nov 23, 2021
@redeboer redeboer mentioned this issue Nov 23, 2021
Merged
@redeboer redeboer mentioned this issue Dec 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
⚠️ Interface Breaking changes to the API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove doit call from SympyModel ComPWA/tensorwaves
1 participant
@redeboer