Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge DataGenerator interface into WeightedDataGenerator interface #456

Closed
redeboer opened this issue Aug 4, 2022 · 0 comments · Fixed by #458
Closed

Merge DataGenerator interface into WeightedDataGenerator interface #456

redeboer opened this issue Aug 4, 2022 · 0 comments · Fixed by #458
Assignees
@redeboer
Labels
⚠️ Interface Breaking changes to the API

Comments

@redeboer
Copy link
Member

redeboer commented Aug 4, 2022

After a discussion with @spflueger: one interface that returns a DataSample with weights suffices. In case there are no weights, return 1 or an array of ones.

This may also help to tackle #402.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
⚠️ Interface Breaking changes to the API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: merge WeightedDataGenerator into DataGenerator redeboer/ComPWA-tensorwaves
1 participant
@redeboer