Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge WeightedDataGenerator into DataGenerator #458

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 9, 2022

Closes #456 and closes #402 in combination with TR-018.

If there are weights, they are provided through the DataSample with a "weights" key.

@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Aug 9, 2022
@redeboer redeboer added this to the 0.4.7 milestone Aug 9, 2022
@redeboer redeboer self-assigned this Aug 9, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer merged commit 642e774 into ComPWA:main Aug 9, 2022
@redeboer redeboer deleted the importance-sampling branch August 9, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Interface Breaking changes to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge DataGenerator interface into WeightedDataGenerator interface Port importance sampling from pycompwa
1 participant