Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: generate deterministic data samples #168

Merged
merged 15 commits into from
Nov 19, 2020
Merged

feat!: generate deterministic data samples #168

merged 15 commits into from
Nov 19, 2020

Conversation

redeboer
Copy link
Member

Closes #59

@redeboer redeboer added this to the Release 0.1.3 milestone Nov 18, 2020
@redeboer redeboer self-assigned this Nov 18, 2020
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #168 (b6027be) into master (d46608a) will increase coverage by 3.69%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   72.55%   76.25%   +3.69%     
==========================================
  Files          12       12              
  Lines         594      598       +4     
  Branches       84       85       +1     
==========================================
+ Hits          431      456      +25     
+ Misses        132      107      -25     
- Partials       31       35       +4     
Flag Coverage Δ
unittests 76.25% <82.35%> (+3.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tensorwaves/data/generate.py 77.77% <50.00%> (+35.18%) ⬆️
src/tensorwaves/data/tf_phasespace.py 93.10% <81.81%> (-2.90%) ⬇️
src/tensorwaves/interfaces.py 100.00% <100.00%> (ø)
...ensorwaves/physics/helicity_formalism/amplitude.py 73.03% <0.00%> (+1.12%) ⬆️

tests/data/test_generate.py Outdated Show resolved Hide resolved
src/tensorwaves/data/tf_phasespace.py Outdated Show resolved Hide resolved
Copy link
Member

@spflueger spflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the important parts of the code for now. I think its best discussed in a short meeting

src/tensorwaves/data/tf_phasespace.py Outdated Show resolved Hide resolved
src/tensorwaves/data/tf_phasespace.py Outdated Show resolved Hide resolved
Copy link
Member

@spflueger spflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redeboer redeboer merged commit e9bb528 into ComPWA:master Nov 19, 2020
@redeboer redeboer deleted the deterministic-data-samples branch November 19, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deterministic behavior for phasespace generator
2 participants