Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add angular distribution tests from pycompwa #182

Merged
merged 30 commits into from
Jan 5, 2021
Merged

Conversation

spflueger
Copy link
Member

@spflueger spflueger commented Dec 9, 2020

First test is ported from pycompwa, together with some fixture code.

I also made a small change to the variable names, as they were not consistent.

The second one I will tackle tomorrow. But this will serve as the baseline for all other distribution test.
@redeboer @Leongrim @sebastianJaeger , take a look if you like the test setup. Ideally I would like you to possibly extend this with your channels.

Closes #181

TODOs:

  • add second pycompwa distribution check
  • add scipy as a test dependency

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #182 (376011f) into master (cd560fa) will increase coverage by 0.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   82.85%   83.66%   +0.80%     
==========================================
  Files          13       13              
  Lines         700      704       +4     
  Branches       96       97       +1     
==========================================
+ Hits          580      589       +9     
+ Misses         87       83       -4     
+ Partials       33       32       -1     
Flag Coverage Δ
unittests 83.66% <100.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ensorwaves/physics/helicity_formalism/amplitude.py 75.74% <100.00%> (+2.16%) ⬆️
...nsorwaves/physics/helicity_formalism/kinematics.py 85.41% <100.00%> (+0.10%) ⬆️

@spflueger
Copy link
Member Author

I would just keep this PR as it is and @Leongrim and @sebastianJaeger can add their channels in follow up PRs. It also reflects the title this way.

Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just have some comments about the structure of the angular_distributions folder. That's related to #182 (comment) as well

Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So apart from #182 (comment), I think we can move on with this PR

@redeboer redeboer merged commit 574fe16 into master Jan 5, 2021
@redeboer redeboer deleted the issue181 branch January 5, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port angular distribution checks from pycompwa
2 participants