Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw invalid L error correctly #188

Merged
merged 2 commits into from
Jan 6, 2021
Merged

fix: throw invalid L error correctly #188

merged 2 commits into from
Jan 6, 2021

Conversation

spflueger
Copy link
Member

@spflueger spflueger commented Jan 6, 2021

  • Throw exception correctly when using helicity formalism
  • Test if the exception is raised as expected

@spflueger spflueger added the 🐛 Bug Something isn't working label Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #188 (7add890) into master (8b69eb8) will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   82.24%   82.41%   +0.16%     
==========================================
  Files          13       13              
  Lines         704      705       +1     
  Branches       97       98       +1     
==========================================
+ Hits          579      581       +2     
+ Misses         90       89       -1     
  Partials       35       35              
Flag Coverage Δ
unittests 82.41% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ensorwaves/physics/helicity_formalism/amplitude.py 75.83% <0.00%> (+0.46%) ⬆️

@spflueger
Copy link
Member Author

We could add a small test, that makes sure this error is thrown when this case actually appears.

@spflueger
Copy link
Member Author

Ok done. Unfortunately the design of the IntensityBuilder makes the testing quite difficult. Hence the rather abstruse test. Improving that design can be put on our Todo list.

Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test! Although the syntax can indeed be improved, hopefully through #162

@redeboer redeboer merged commit e0b02d4 into master Jan 6, 2021
@redeboer redeboer deleted the fix-invalid-L branch January 6, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants