Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: move requirements back to setup.cfg #264

Merged
merged 7 commits into from
Apr 15, 2021
Merged

build!: move requirements back to setup.cfg #264

merged 7 commits into from
Apr 15, 2021

Conversation

redeboer
Copy link
Member

With the release of pip-tools v6.1.0, pip-compile now correctly handles extras_require. This allows for a big clean-up of the set-up introduced by ComPWA/expertsystem#412.

Advantages:

  • Easier for the user and developer! Just run:
    pip install -e .[dev]
    to get started developing,
    pip install -e .[dev] -U
    to try out upgrades, and
    pip install -c .constraints/py3.8.txt -e .[dev] -U
    in case you exactly want to reproduce the dependencies for some commit.
  • The upgrade jobs become significantly faster: bit over 1min versus almost 3min
  • All requirements, their version domains, and the dependencies between each of the requirement sections can be nicely overseen and maintained within setup.cfg
  • Git diffs for pull requests that affect dependencies become easier to oversee
  • Less complexity and fewer changes per commit

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Apr 15, 2021
@redeboer redeboer self-assigned this Apr 15, 2021
@redeboer redeboer added this to the Release 0.2.4 milestone Apr 15, 2021
Seems that git diff does not work well if there are new files (as
opposed to modified files)
@redeboer redeboer merged commit 5fbcc19 into main Apr 15, 2021
@redeboer redeboer deleted the constraints branch April 15, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant