Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support data generation with jax #271

Merged
merged 1 commit into from
May 11, 2021
Merged

fix: support data generation with jax #271

merged 1 commit into from
May 11, 2021

Conversation

redeboer
Copy link
Member

Simple fix: just casts ScalarSequence back into a numpy array so that a lambdified Function can handle it.

@redeboer redeboer added the 🐛 Bug Something isn't working label May 11, 2021
@redeboer redeboer requested a review from Leongrim May 11, 2021 08:01
@redeboer redeboer self-assigned this May 11, 2021
@redeboer
Copy link
Member Author

Next step would be to allow feeding an Estimator a LambdifiedFunction directly. This is useful if lambdifying takes a long time.

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #271 (943bb4b) into main (66e24e0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   84.08%   84.12%   +0.04%     
==========================================
  Files          13       13              
  Lines         754      756       +2     
==========================================
+ Hits          634      636       +2     
  Misses        120      120              
Flag Coverage Δ
unittests 84.12% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tensorwaves/data/transform.py 100.00% <100.00%> (ø)

@redeboer redeboer enabled auto-merge (squash) May 11, 2021 08:05
@redeboer redeboer merged commit 18acfa7 into main May 11, 2021
@redeboer redeboer deleted the jax-data branch May 11, 2021 08:08
@redeboer redeboer added this to the 0.2.6 milestone May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants