fix: lambdify ComplexSqrt to TensorFlow
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
added a commit
that referenced
this pull request
Dec 7, 2021
* chore: define custom _TensorflowPrinter * chore: extract _replace_module function * chore: forward JAX ComplexSqrt printer to numpycode * chore: move _backend to function sub-module * feat: expand available functions in TF printer * fix: improve find_function exception message * fix: lambdify ComplexSqrt to TensorFlow * test: lambdify ComplexSqrt with different backends * test: try more functions in test_find_function
redeboer
changed the title
ComplexSqrt to TensorFlow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAX and TensorFlow printing is forwarded to the NumPy printer, but with
jax.numpyandtensorflow.experimental.numpyasPrinter._modulerespectively.Other improvements:
find_functionand wrote a test for lambdifying AmpForm'sComplexSqrttensorflow.Tensorwithfind_function_backendmodule tofunction, becausefunctionis most related to back-ends.