Comment functionality on shared and synchronized collections #699 #1237

TasnimMehzabin · 2023-03-24T11:15:10Z

Closes #563

app/api/chemotion/collection_api.rb

app/api/chemotion/screen_api.rb

app/api/helpers/comment_helpers.rb

app/models/collection.rb

app/models/comment.rb

spec/api/comment_api_spec.rb

github-actions · 2023-03-27T17:09:33Z

spec/api/comment_api_spec.rb

+        end
+      end
+
+      context 'with reaction' do


RSpec/NestedGroups: Maximum example group nesting exceeded [4/3].

spec/api/comment_api_spec.rb

github-actions · 2023-03-28T09:08:19Z

spec/api/comment_api_spec.rb

+    end
+  end
+
+  context 'when user is authorized' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [23/10]

spec/api/comment_api_spec.rb

github-actions · 2023-03-28T09:08:24Z

spec/api/comment_api_spec.rb

+      end
+    end
+
+    describe 'PUT /api/v1/comments/:id' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [23/10]

github-actions · 2023-03-28T09:08:24Z

spec/api/comment_api_spec.rb

+    end
+
+    describe 'PUT /api/v1/comments/:id' do
+      context 'with only content' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [25/10]

github-actions · 2023-03-28T09:08:24Z

spec/api/comment_api_spec.rb

+    end
+
+    describe 'PUT /api/v1/comments/:id' do
+      context 'with only content' do


RSpec/NestedGroups: Maximum example group nesting exceeded [4/3].

spec/api/comment_api_spec.rb

github-actions · 2023-03-28T10:13:42Z

spec/api/comment_api_spec.rb

+    end
+  end
+
+  context 'when user is authorized' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [15/10]

github-actions · 2023-03-28T10:13:42Z

spec/api/comment_api_spec.rb

+      allow_any_instance_of(WardenAuthentication).to receive(:current_user).and_return(author_user)
+    end
+
+    describe 'GET /api/v1/comments/:id' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [16/10]

github-actions · 2023-03-28T10:13:43Z

spec/api/comment_api_spec.rb

+      end
+    end
+
+    describe 'POST /api/v1/comments/create' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [15/10]

github-actions · 2023-03-28T10:13:43Z

spec/api/comment_api_spec.rb

+    end
+
+    describe 'POST /api/v1/comments/create' do
+      context 'with content' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [16/10]

github-actions · 2023-03-28T10:13:43Z

spec/api/comment_api_spec.rb

+        end
+      end
+
+      context 'with sample' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [16/10]

github-actions · 2023-03-28T10:13:44Z

spec/api/comment_api_spec.rb

+        end
+      end
+
+      context 'with sample' do


RSpec/NestedGroups: Maximum example group nesting exceeded [4/3].

github-actions · 2023-03-28T10:13:44Z

spec/api/comment_api_spec.rb

+        end
+      end
+
+      context 'with reaction' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [17/10]

github-actions · 2023-03-28T10:13:44Z

spec/api/comment_api_spec.rb

+        end
+      end
+
+      context 'with reaction' do


RSpec/NestedGroups: Maximum example group nesting exceeded [4/3].

github-actions · 2023-03-28T10:13:45Z

spec/api/comment_api_spec.rb

+      end
+    end
+
+    describe 'DELETE /api/v1/comments/:id' do


RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [16/10]

spec/models/comment_spec.rb

github-actions · 2023-04-04T21:47:28Z

LCOV of commit `8e67d16` during Continuous Integration #791

Summary coverage rate:
  lines......: 60.0% (11872 of 19777 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions · 2023-04-20T13:16:37Z

LCOV of commit `2a08311` during Continuous Integration #872

Summary coverage rate:
  lines......: 60.1% (11873 of 19767 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions · 2023-04-26T15:28:21Z

LCOV of commit `6e0f459` during Continuous Integration #914

Summary coverage rate:
  lines......: 60.4% (11935 of 19766 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions · 2023-05-03T09:19:25Z

LCOV of commit `1c81d6b` during Continuous Integration #937

Summary coverage rate:
  lines......: 60.4% (11932 of 19765 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions · 2023-05-17T11:25:27Z

LCOV of commit `0909bd3` during Continuous Integration #977

Summary coverage rate:
  lines......: 60.4% (11950 of 19787 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

spec/api/chemotion/comment_api_spec.rb

… lists - Comments are associated with Wellplate, Screen, Research plan - Code is refactored

…earchPlan - Comment section is added in standard tabs in Reaction, Screen, Wellplate, ResearchPlan - Code is modified to make generic - Code is refactored

- Comment section name is generalized - Comment section is hidden if element is being created

- From general comments, user can see all other details comment - From section specific comments, user can see all other details comment

- Code is refactored - Deploy file change is reverted

- axios package is removed

refactor folder structure for Comments components

…fic users only add comment matrice show the comment icon, comment header button based on the UI activation upon matrix check remove unnecessary code

refactor the code

add test code for synchronized collections

- it will notify all users with access to the element - it will notify all group members when the group has access to the element

reload the comments when the header comment button or the comment button within the details tabs are clicked fix the notification to display the element type and element name refactor the implementation of the notification to fix the collection owner not getting the notification on new comments reposition the comment button in the header section

cleanup the schema.rb

…rary refactor the comment_api.rb codes

fix the comment_api_spec.rb file for the updated create API endpoint fix the association issue

github-actions · 2023-06-26T09:47:13Z

spec/factories/comment.rb

+FactoryBot.define do
+  factory :comment do
+    transient do
+      user { create(:user) }


FactoryBot/FactoryAssociationWithStrategy: Use an implicit, explicit or inline definition instead of hard coding a strategy for setting association within factory.

github-actions · 2023-06-26T10:07:49Z

LCOV of commit `7389cfe` during Continuous Integration #1176

Summary coverage rate:
  lines......: 60.9% (12477 of 20485 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

) * Comment polymorphic model * associated to Sample Reaction RP screeen Wellplate * Notification to users

TasnimMehzabin changed the base branch from main to 498-inbox-font-fixes March 24, 2023 11:15

TasnimMehzabin changed the base branch from 498-inbox-font-fixes to main March 24, 2023 11:15

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 8bd958b to 53218e9 Compare March 24, 2023 13:28

github-actions bot reviewed Mar 24, 2023

View reviewed changes

TasnimMehzabin marked this pull request as draft March 24, 2023 20:27

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 53218e9 to 3250e1c Compare March 27, 2023 17:07

TasnimMehzabin marked this pull request as ready for review March 27, 2023 17:08

github-actions bot reviewed Mar 27, 2023

View reviewed changes

github-actions bot reviewed Mar 28, 2023

View reviewed changes

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 3b4d36c to 1aee79c Compare March 28, 2023 10:11

github-actions bot reviewed Mar 28, 2023

View reviewed changes

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch 3 times, most recently from f78381f to 95fd46b Compare March 29, 2023 09:40

PiTrem marked this pull request as draft April 4, 2023 08:18

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 95fd46b to 8e67d16 Compare April 4, 2023 21:28

TasnimMehzabin marked this pull request as ready for review April 5, 2023 14:38

TasnimMehzabin marked this pull request as draft April 5, 2023 14:38

TasnimMehzabin marked this pull request as ready for review April 6, 2023 08:25

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 8e67d16 to 2a08311 Compare April 20, 2023 12:54

TasnimMehzabin requested a review from adambasha0 April 26, 2023 13:49

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 6e0f459 to 1c81d6b Compare May 3, 2023 08:56

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 1c81d6b to 0909bd3 Compare May 17, 2023 11:02

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 0909bd3 to 7cdf91e Compare May 31, 2023 08:11

github-actions bot reviewed May 31, 2023

View reviewed changes

TasnimMehzabin added 19 commits June 23, 2023 17:56

- Comment icon is added in Reaction, Wellplate, Screen, Research plan…

be0f492

… lists - Comments are associated with Wellplate, Screen, Research plan - Code is refactored

- Header comment section is added in Reaction, Screen, Wellplate, Res…

9f0c342

…earchPlan - Comment section is added in standard tabs in Reaction, Screen, Wellplate, ResearchPlan - Code is modified to make generic - Code is refactored

- Comment authorization is modified for the shared users

e1e67ab

- Comment section name is generalized - Comment section is hidden if element is being created

- Comment resolved by column is added

e4e457f

- From general comments, user can see all other details comment - From section specific comments, user can see all other details comment

[563] - Migrations files for comments table is merged

897fd18

- Code is refactored - Deploy file change is reverted

[563] - fetch is used replacing axios for comment API

00b9015

- axios package is removed

[563] refactor/fix rebase changes

a7cf948

[563] fix rubocop warnings

bcf18c5

refactor folder structure for Comments components

add UI feature for comment components so that it is enabled for speci…

e04ef64

…fic users only add comment matrice show the comment icon, comment header button based on the UI activation upon matrix check remove unnecessary code

refactor the code with CommentStore and CommentActions

01caba7

fix the issue with comment manipulation in the details section

71f2514

format comment created time

5045173

fix the issue with comment created time

5d11282

refactor the code

refactor and add test codes

28205fe

refactor the code

add test code for collections shared with group

cf9ce65

add test code for synchronized collections

refactor the notification implementation when a comment is created

e03f0a7

- it will notify all users with access to the element - it will notify all group members when the group has access to the element

refactor the comment_api.rb codes

c9bce10

cleanup the schema.rb

implement the confirm window before comment deletion removing the lib…

8c0fa3c

…rary refactor the comment_api.rb codes

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 30c92f4 to 05ea853 Compare June 23, 2023 15:56

TasnimMehzabin marked this pull request as ready for review June 23, 2023 17:03

refactor the comment_api.rb

1804971

fix the comment_api_spec.rb file for the updated create API endpoint fix the association issue

TasnimMehzabin force-pushed the 563-comment-on-shared-synced-collection branch from 05ea853 to 1804971 Compare June 26, 2023 05:31

fix the comment_spec.rb for the creator issue

7389cfe

github-actions bot reviewed Jun 26, 2023

View reviewed changes

PiTrem approved these changes Jun 26, 2023

View reviewed changes

PiTrem merged commit 5bf60a1 into main Jun 27, 2023
2 of 3 checks passed

mekkyz pushed a commit that referenced this pull request Sep 21, 2023

Comment functionality on shared and synchronized collections #699 (#1237

0df5ca1

) * Comment polymorphic model * associated to Sample Reaction RP screeen Wellplate * Notification to users

baolanlequang pushed a commit that referenced this pull request Mar 5, 2024

Comment functionality on shared and synchronized collections #699 (#1237

c396a2f

) * Comment polymorphic model * associated to Sample Reaction RP screeen Wellplate * Notification to users

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comment functionality on shared and synchronized collections #699 #1237

Comment functionality on shared and synchronized collections #699 #1237

TasnimMehzabin commented Mar 24, 2023 •

edited

github-actions bot Mar 27, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot Mar 28, 2023

github-actions bot commented Apr 4, 2023

github-actions bot commented Apr 20, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented May 3, 2023

github-actions bot commented May 17, 2023

github-actions bot Jun 26, 2023

github-actions bot commented Jun 26, 2023

Comment functionality on shared and synchronized collections #699 #1237

Comment functionality on shared and synchronized collections #699 #1237

Conversation

TasnimMehzabin commented Mar 24, 2023 • edited

github-actions bot Mar 27, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 4, 2023

LCOV of commit 8e67d16 during Continuous Integration #791

github-actions bot commented Apr 20, 2023

LCOV of commit 2a08311 during Continuous Integration #872

github-actions bot commented Apr 26, 2023

LCOV of commit 6e0f459 during Continuous Integration #914

github-actions bot commented May 3, 2023

LCOV of commit 1c81d6b during Continuous Integration #937

github-actions bot commented May 17, 2023

LCOV of commit 0909bd3 during Continuous Integration #977

github-actions bot Jun 26, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 26, 2023

LCOV of commit 7389cfe during Continuous Integration #1176

TasnimMehzabin commented Mar 24, 2023 •

edited

LCOV of commit `8e67d16` during Continuous Integration #791

LCOV of commit `2a08311` during Continuous Integration #872

LCOV of commit `6e0f459` during Continuous Integration #914

LCOV of commit `1c81d6b` during Continuous Integration #937

LCOV of commit `0909bd3` during Continuous Integration #977

LCOV of commit `7389cfe` during Continuous Integration #1176