Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shib #1239

Merged
merged 1 commit into from
Mar 28, 2023
Merged

shib #1239

merged 1 commit into from
Mar 28, 2023

Conversation

phuang26
Copy link
Member

@phuang26 phuang26 commented Mar 24, 2023 •
edited by PiTrem

implement Shibboleth authentication

  • auth config done through the AdminUI FeatureUI, not through config/*.yml anymore
    image

  • split admin api into separate domains (admin, admin_user, admin_generic)

@phuang26 phuang26 requested a review from cllde8 March 24, 2023 15:26
github-actions[bot]
github-actions bot reviewed Mar 24, 2023
View reviewed changes
app/api/chemotion/admin_generic_api.rb Show resolved Hide resolved
app/api/chemotion/admin_generic_api.rb Show resolved Hide resolved
app/api/chemotion/admin_generic_api.rb Show resolved Hide resolved
app/api/chemotion/admin_generic_api.rb Show resolved Hide resolved
app/api/chemotion/admin_generic_api.rb Show resolved Hide resolved
app/api/chemotion/admin_user_api.rb Show resolved Hide resolved
app/api/chemotion/public_api.rb Show resolved Hide resolved
app/controllers/application_controller.rb Show resolved Hide resolved
app/controllers/users/omniauth_controller.rb Show resolved Hide resolved
app/models/user.rb Show resolved Hide resolved
@github-actions
Copy link

LCOV of commit d7b1c4a during Continuous Integration #740

Summary coverage rate:
  lines......: 59.8% (11725 of 19610 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@phuang26 phuang26 linked an issue Mar 24, 2023 that may be closed by this pull request
Shibboleth Identity Provider needed #535
Closed
@schatzsc schatzsc mentioned this pull request Mar 27, 2023
Closed
PiTrem
PiTrem reviewed Mar 28, 2023
View reviewed changes
config/initializers/devise.rb
@@ -239,41 +238,78 @@
# Add a new OmniAuth provider. Check the wiki for more information on setting
# up on your models and hooks.
# config.omniauth :github, 'APP_ID', 'APP_SECRET', scope: 'user,public_repo'
omniauth_config = (File.exist? Rails.root.join('config', 'omniauth.yml')) && (Rails.application.config_for :omniauth)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so config/omniauth.yml is not needed / can be removed then ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you can remove them from the server.

@PiTrem PiTrem merged commit a47dd3a into main Mar 28, 2023
@PiTrem PiTrem added this to the v1.6 milestone Mar 28, 2023
@phuang26 phuang26 self-assigned this Apr 11, 2023
mekkyz pushed a commit that referenced this pull request Sep 21, 2023
@phuang26 @mekkyz
shibboleth (#1239)
7757c2a
baolanlequang pushed a commit that referenced this pull request Mar 5, 2024
@phuang26
shibboleth (#1239)
c59fc24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiTrem PiTrem PiTrem left review comments

@github-actions github-actions[bot] github-actions left review comments

@cllde8 cllde8 cllde8 approved these changes

Assignees

@phuang26 phuang26

Labels
None yet
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Shibboleth Identity Provider needed
3 participants
@phuang26 @PiTrem @cllde8