Cas datamodel change #1287
Merged
Cas datamodel change #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
LCOV of commit
|
LCOV of commit
|
mehreenmansur
force-pushed
the
change-cas-datamodel
branch
from
f40be6d
to
ae57c35
Compare
LCOV of commit
|
LCOV of commit
|
mehreenmansur
force-pushed
the
change-cas-datamodel
branch
from
ae57c35
to
3a10af6
Compare
LCOV of commit
|
LCOV of commit
|
adambasha0
force-pushed
the
change-cas-datamodel
branch
from
ee37421
to
b360f16
Compare
PiTrem
requested changes
Apr 27, 2023
LCOV of commit
|
adambasha0
force-pushed
the
change-cas-datamodel
branch
from
b360f16
to
c6537d0
Compare
LCOV of commit
|
mehreenmansur
force-pushed
the
change-cas-datamodel
branch
from
c6537d0
to
ce20eab
Compare
LCOV of commit
|
mehreenmansur
force-pushed
the
change-cas-datamodel
branch
from
2c095db
to
7e80a02
Compare
mehreenmansur
force-pushed
the
change-cas-datamodel
branch
from
19cf8e0
to
4cf244a
Compare
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
PiTrem
requested changes
May 2, 2023
LCOV of commit
|
mehreenmansur
force-pushed
the
change-cas-datamodel
branch
from
78112be
to
bc80b00
Compare
LCOV of commit
|
PiTrem
approved these changes
May 3, 2023
PiTrem
pushed a commit
that referenced
this pull request
May 9, 2023
* add migration to change cas value * cas number string searchable * update cas structure in frontend sample create * update scope for sample cas * update spec sample cas data * rubocop fixes * update sample xref method * fix error white screen after clicking on CAS-Nummer field * update sample cas suggestion query --------- Co-authored-by: Mehreen <mehreen.mansur> Co-authored-by: fathia <f.idiris1@gmail.com> Co-authored-by: nh9378 <basha.adam@kit.edu>
dpatelev
pushed a commit
that referenced
this pull request
May 10, 2023
* add migration to change cas value * cas number string searchable * update cas structure in frontend sample create * update scope for sample cas * update spec sample cas data * rubocop fixes * update sample xref method * fix error white screen after clicking on CAS-Nummer field * update sample cas suggestion query --------- Co-authored-by: Mehreen <mehreen.mansur> Co-authored-by: fathia <f.idiris1@gmail.com> Co-authored-by: nh9378 <basha.adam@kit.edu>
mekkyz
pushed a commit
that referenced
this pull request
Sep 21, 2023
* add migration to change cas value * cas number string searchable * update cas structure in frontend sample create * update scope for sample cas * update spec sample cas data * rubocop fixes * update sample xref method * fix error white screen after clicking on CAS-Nummer field * update sample cas suggestion query --------- Co-authored-by: Mehreen <mehreen.mansur> Co-authored-by: fathia <f.idiris1@gmail.com> Co-authored-by: nh9378 <basha.adam@kit.edu>
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
* add migration to change cas value * cas number string searchable * update cas structure in frontend sample create * update scope for sample cas * update spec sample cas data * rubocop fixes * update sample xref method * fix error white screen after clicking on CAS-Nummer field * update sample cas suggestion query --------- Co-authored-by: Mehreen <mehreen.mansur> Co-authored-by: fathia <f.idiris1@gmail.com> Co-authored-by: nh9378 <basha.adam@kit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1279
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release