1267 reactants from reagent list do not appear above reaction arrow #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/svg/reaction_composer.rb
Outdated
| @@ -425,10 +425,11 @@ def inner_file_content(svg_path) | |||
| return unless File.file?(file) | |||
|
|
|||
| doc = Nokogiri::XML(File.open(file)) | |||
|
|
|||
There was a problem hiding this comment.
Metrics/ClassLength: Class has too many lines. [546/200]
LCOV of commit
|
need the ketcher rendering service. examples: - reprocess missing molecule SVGs: `rake svg:molecule` - reprocess all molecule SVGs with molecule id >= 200: `rake 'svg:molecule[all, 200]'` - reprocess missing sample SVGs with sample 100 <= id <= 200: `rake 'svg:sample[missing, 100, 200]'` - reprocess openbabel generated molecule SVGs: `rake 'svg:molecule[openbabel]'`
PiTrem
force-pushed
the
1267-reactants-from-reagent-list-do-not-appear-above-reaction-arrow
branch
from
99f21bf
to
868477d
Compare
| @@ -428,7 +428,7 @@ def inner_file_content(svg_path) | |||
| if svg_path.include?('/samples') | |||
| doc.at_css('svg') | |||
| else | |||
| doc.at_css('g svg') | |||
| doc.at_css('g svg').presence || doc.at_css('svg') | |||
There was a problem hiding this comment.
Metrics/ClassLength: Class has too many lines. [546/200]
LCOV of commit
|
PiTrem
added a commit
that referenced
this pull request
May 9, 2023
…1308) * fall back to another css selector for molecule molfile (ketcher srv generated) * rake tasks to reprocess molecule/sample svg: needs the ketcher rendering service. Timestamps are not updated. examples: - reprocess missing molecule SVGs: `rake svg:molecule` - reprocess all molecule SVGs with molecule id >= 200: `rake 'svg:molecule[all, 200]'` - reprocess missing sample SVGs with sample 100 <= id <= 200: `rake 'svg:sample[missing, 100, 200]'` - reprocess openbabel generated molecule SVGs: `rake 'svg:molecule[openbabel]'`
dpatelev
pushed a commit
that referenced
this pull request
May 10, 2023
…1308) * fall back to another css selector for molecule molfile (ketcher srv generated) * rake tasks to reprocess molecule/sample svg: needs the ketcher rendering service. Timestamps are not updated. examples: - reprocess missing molecule SVGs: `rake svg:molecule` - reprocess all molecule SVGs with molecule id >= 200: `rake 'svg:molecule[all, 200]'` - reprocess missing sample SVGs with sample 100 <= id <= 200: `rake 'svg:sample[missing, 100, 200]'` - reprocess openbabel generated molecule SVGs: `rake 'svg:molecule[openbabel]'`
mekkyz
pushed a commit
that referenced
this pull request
Sep 21, 2023
…1308) * fall back to another css selector for molecule molfile (ketcher srv generated) * rake tasks to reprocess molecule/sample svg: needs the ketcher rendering service. Timestamps are not updated. examples: - reprocess missing molecule SVGs: `rake svg:molecule` - reprocess all molecule SVGs with molecule id >= 200: `rake 'svg:molecule[all, 200]'` - reprocess missing sample SVGs with sample 100 <= id <= 200: `rake 'svg:sample[missing, 100, 200]'` - reprocess openbabel generated molecule SVGs: `rake 'svg:molecule[openbabel]'`
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
…1308) * fall back to another css selector for molecule molfile (ketcher srv generated) * rake tasks to reprocess molecule/sample svg: needs the ketcher rendering service. Timestamps are not updated. examples: - reprocess missing molecule SVGs: `rake svg:molecule` - reprocess all molecule SVGs with molecule id >= 200: `rake 'svg:molecule[all, 200]'` - reprocess missing sample SVGs with sample 100 <= id <= 200: `rake 'svg:sample[missing, 100, 200]'` - reprocess openbabel generated molecule SVGs: `rake 'svg:molecule[openbabel]'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fall back to another css selector in case the molecule SVG was created by ketchersrv
added rake task to regenerate sample/molecule SVGs