Communication between Third Party Apps and the ELN #1353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code enables the communication of the ELN with third party apps (TPAs) - in the admin dashboard code is added to register TPAs (name and ip address) - in the research plan/attachment the user can send files to TPAs - The public api contains method for TPAs to download or upload a file
Adapted the fetchers to the modifications
- the download and upload routes are moved from public_api.rb to third_party_apps_api.rb - updated tests - test that user is admin is now conducted analogous as in admin_api.rb
…e name is unique is now handled at the backend site
- Moreover, a counter for each token is cached. Any third party app is only allowed to upload 30 files.
- within the cache the token itself, a counter and the name of the third party app is stored+ - the upload and download to/from the ELN by the third party app is limited by the counter
…ThirdPartyAppNames Merge remote-tracking branch 'local/Third-Party-Apps' into Third-Party-Apps
…ty apps. The third party app uses this ip address to make get and post request
Merge remote-tracking branch 'local/Third-Party-Apps' into Third-Party-Apps
|
moved to #1832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code enables the communication of the ELN with third-party apps (TPAs)
in the admin dashboard code is added to register TPAs (name and IP address)
in the research plan/attachment the user can send files to TPAs
The public API contains methods for TPAs to download or upload a file
[x ] rather 1-story 1-commit than sub-atomic commits
[ x] commit title is meaningful => git history search
[ x] commit description is helpful => helps the reviewer to understand the changes
[ x] code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
[ x] added code is linted
[ x] tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing.
- I have written a documentation. Pierre has the file. I'm not sure what is the best way to make it public.
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )