-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notification timestamps and formatting notification button #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were changes to the style of the inbox button 2 days ago. I changed it so that the icon will be centered and the two buttons will be of exact size and looks |
LCOV of commit
|
LCOV of commit
|
ptrxyz
previously requested changes
Jun 23, 2023
LCOV of commit
|
LCOV of commit
|
PiTrem
approved these changes
Jun 27, 2023
mekkyz
added a commit
that referenced
this pull request
Sep 21, 2023
* notification timestamps, format notification button * styling inbox and notifications buttons * unit test for timezoneHelper * using Moment.js to correctly get the timezone * using timezone info from backend
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
* notification timestamps, format notification button * styling inbox and notifications buttons * unit test for timezoneHelper * using Moment.js to correctly get the timezone * using timezone info from backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/ComPlat/chemotion/issues/12
Fixes https://github.com/ComPlat/chemotion/issues/20
What is new for users:
This is how it was when there were no notifications.
![](https://camo.githubusercontent.com/4210e75681478c32de7a9d6cf4607e3bf85547e8159bea3f6e6fc126cb911432/68747470733a2f2f63646e2e646973636f72646170702e636f6d2f6174746163686d656e74732f313131393234373737303836343332383738382f313132313337363033363636383537393834302f696d6167652e706e67)
And now:
![](https://camo.githubusercontent.com/22d61d21c4f8984463450695acc7d5f645aefdbd62ed6f1f2f5fda6da5dc389e/68747470733a2f2f63646e2e646973636f72646170702e636f6d2f6174746163686d656e74732f313131393234373737303836343332383738382f313132313339383439353931363630313434352f696d6167652e706e67)
When there are notifications
![](https://camo.githubusercontent.com/837c80968f00cd4afca9efe763c8993776af19bbef89c8f0ba9ba8342ac8024c/68747470733a2f2f63646e2e646973636f72646170702e636f6d2f6174746163686d656e74732f313131393234373737303836343332383738382f313132313337363234343236353635323333372f696d6167652e706e67)
And now:
![](https://camo.githubusercontent.com/4d582731ee1d03ad2c9c24e36122f091b993efbb032043568c2060a2755bd27e/68747470733a2f2f63646e2e646973636f72646170702e636f6d2f6174746163686d656e74732f313131393234373737303836343332383738382f313132313337373034303230363134333438392f696d6167652e706e67)