Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification timestamps and formatting notification button #1362

Merged
merged 9 commits into from
Jun 27, 2023

Conversation

mekkyz
Copy link
Contributor

@mekkyz mekkyz commented Jun 22, 2023

Fixes https://github.com/ComPlat/chemotion/issues/12
Fixes https://github.com/ComPlat/chemotion/issues/20

  • used "prettier" to reformat the code.
  • solved eslint issues
  • getting the timezone String from backend to correctly present the local time
  • DidMount has now startActivityDetection to make the notification button always available
  • Did some ui change on the notification button because its size and centering were off

What is new for users:

  • the notification button is now a bell instead of the messaging icon and be always shown in the default status when notification = 0.
  • it will change to yellow and notification counter will start counting whenever there are notifications
  • the text "message" is now "notification"
  • the button has now the right size comparable to the button next to it.
  • the icon is now centered in the button.

This is how it was when there were no notifications.

And now:

When there are notifications

And now:

@mekkyz
Copy link
Contributor Author

mekkyz commented Jun 22, 2023

There were changes to the style of the inbox button 2 days ago. I changed it so that the icon will be centered and the two buttons will be of exact size and looks

@github-actions
Copy link

LCOV of commit 4267267 during Continuous Integration #1150

Summary coverage rate:
  lines......: 60.6% (12313 of 20309 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit ba2f02f during Continuous Integration #1152

Summary coverage rate:
  lines......: 60.6% (12313 of 20309 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

ptrxyz
ptrxyz previously requested changes Jun 23, 2023
app/packs/src/utilities/timezoneHelper.js Outdated Show resolved Hide resolved
spec/javascripts/utils/timezoneHelper.spec.js Outdated Show resolved Hide resolved
@github-actions
Copy link

LCOV of commit 5017cf6 during Continuous Integration #1175

Summary coverage rate:
  lines......: 60.6% (12313 of 20309 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit 2810378 during Continuous Integration #1180

Summary coverage rate:
  lines......: 60.6% (12315 of 20308 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit ee600b0 into main Jun 27, 2023
3 checks passed
mekkyz added a commit that referenced this pull request Sep 21, 2023
* notification timestamps, format notification button

* styling inbox and notifications buttons

* unit test for timezoneHelper

* using Moment.js to correctly get the timezone

* using timezone info from backend
baolanlequang pushed a commit that referenced this pull request Mar 5, 2024
* notification timestamps, format notification button

* styling inbox and notifications buttons

* unit test for timezoneHelper

* using Moment.js to correctly get the timezone

* using timezone info from backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants