Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cypress complaint attributes #1365

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

mehmood86
Copy link
Contributor

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

@mehmood86 mehmood86 requested a review from PiTrem June 23, 2023 07:48
@github-actions
Copy link

LCOV of commit 8bc3e70 during Continuous Integration #1158

Summary coverage rate:
  lines......: 60.6% (12313 of 20309 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@mehmood86 mehmood86 merged commit c590476 into main Jun 23, 2023
3 checks passed
@PiTrem PiTrem self-requested a review June 23, 2023 09:16
@JanCBrammer JanCBrammer deleted the researchPlan-add-cypress-attributes branch July 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants