Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login-and-signup-configurable #1377

Merged
merged 1 commit into from
Jun 29, 2023
Merged

login-and-signup-configurable #1377

merged 1 commit into from
Jun 29, 2023

Conversation

phuang26
Copy link
Member

  1. configurable option to enable or disable database login.
  2. configurable option to enable or disable database signup.
  3. configurable option for shibboleth label/icon.
  4. rename "group" in signup.
  5. modify the wording associated with RADAR.
  6. Remove unused code.

@phuang26 phuang26 requested a review from cllde8 June 28, 2023 12:39
@phuang26 phuang26 force-pushed the login-and-signup-configurable branch from 1522601 to 597c414 Compare June 28, 2023 12:41
github-actions[bot]
github-actions bot reviewed Jun 28, 2023
View reviewed changes
app/api/chemotion/public_api.rb Outdated Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
@github-actions
Copy link

LCOV of commit 597c414 during Continuous Integration #1192

Summary coverage rate:
  lines......: 59.4% (12270 of 20663 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@phuang26 phuang26 force-pushed the login-and-signup-configurable branch from 597c414 to a49281b Compare June 28, 2023 13:26
github-actions[bot]
github-actions bot reviewed Jun 28, 2023
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
@phuang26 phuang26 force-pushed the login-and-signup-configurable branch from a49281b to b963364 Compare June 28, 2023 13:34
@github-actions
Copy link

LCOV of commit a49281b during Continuous Integration #1194

Summary coverage rate:
  lines......: 59.4% (12267 of 20664 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit b963364 during Continuous Integration #1195

Summary coverage rate:
  lines......: 59.4% (12270 of 20664 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit 34ddbfe into main Jun 29, 2023
3 checks passed
@phuang26 phuang26 deleted the login-and-signup-configurable branch June 30, 2023 07:17
@phuang26 phuang26 self-assigned this Jun 30, 2023
PiTrem pushed a commit that referenced this pull request Jul 7, 2023
@phuang26 @PiTrem
login-and-signup-configurable (#1377)
61b6412
mekkyz pushed a commit that referenced this pull request Sep 21, 2023
@phuang26 @mekkyz
login-and-signup-configurable (#1377)
68c61e9
@crsoph crsoph mentioned this pull request Oct 9, 2023
Closed
baolanlequang pushed a commit that referenced this pull request Mar 5, 2024
@phuang26
login-and-signup-configurable (#1377)
803cae1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@cllde8 cllde8 cllde8 approved these changes

Assignees

@phuang26 phuang26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phuang26 @cllde8 @PiTrem