create user test and researchplan extended test are added #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
JanCBrammer
reviewed
Jun 30, 2023
| @@ -13,4 +13,36 @@ describe('Research Plan with User', () => { | |||
| cy.contains('My Research Plan 2'); | |||
| cy.get('#tabList-tab-4 > span').contains('1(0)'); | |||
| }); | |||
|
|
|||
| it('rename research plan', () => { | |||
There was a problem hiding this comment.
I ran this tests locally with yarn cypress run --project spec --spec "spec/cypress/end_to_end/research_plan_with_user.cy.js", and it fails with
1) Research Plan with User
rename research plan:
AssertionError: Timed out retrying after 5000ms: Expected to find element: `[width="280px"] > :nth-child(1) > .preview-table`, but never found it.
at Context.eval (webpack:///./cypress/end_to_end/research_plan_with_user.cy.js:9:7)
2) Research Plan with User
rename research plan:
AssertionError: Timed out retrying after 5000ms: Expected to find element: `[width="280px"] > :nth-child(1) > .preview-table`, but never found it.
at Context.eval (webpack:///./cypress/end_to_end/research_plan_with_user.cy.js:24:7)
Not sure if it fails because of a timeout on my machine or because the selector ('[width="280px"] > :nth-child(1) > .preview-table') is too brittle?
There was a problem hiding this comment.
Dont know, it runs fine on my end. But anyway I added cypress identifier for this part and I hope now it should work seamlessly.
There was a problem hiding this comment.
I increased the timeout from 5000 to 10000 and tried running on chrome instead of electron, Still won't work 🤔
1) Research Plan with User
rename research plan:
AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="researchPLanItem-1"]`, but never found it.
at Context.eval (webpack:///./cypress/end_to_end/research_plan_with_user.cy.js:9:7)
2) Research Plan with User
add/remove fields in research plan:
AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="researchPLanItem-1"]`, but never found it.
at Context.eval (webpack:///./cypress/end_to_end/research_plan_with_user.cy.js:24:7)
There was a problem hiding this comment.
The test now passed on my machine.
LCOV of commit
|
…end_to_end_tests_ext latest head from main branch merged into end_to_end_tests_ext branch
LCOV of commit
|
JanCBrammer
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Looks good to me.
We removed the collection API tests for now since they (at least conceptually) replicate
https://github.com/ComPlat/chemotion_ELN/blob/0190e0fcdc35d62d84107e465a7941030bdee259/spec/api/collection_api_spec.rb.
LCOV of commit
|
mehreenmansur
pushed a commit
that referenced
this pull request
Jul 14, 2023
* create user test and researchplan extended test are added * added identifier to eliminate flakyness in researcPlan cypress-specs * collections api spec is now added * deleted unnecessary comments from collection_api_spec.cy.js * Remove redundant API test for now (conceptually replicated RSpec) --------- Co-authored-by: Jan C. Brammer <jan.c.brammer@gmail.com>
mehreenmansur
pushed a commit
that referenced
this pull request
Jul 31, 2023
* create user test and researchplan extended test are added * added identifier to eliminate flakyness in researcPlan cypress-specs * collections api spec is now added * deleted unnecessary comments from collection_api_spec.cy.js * Remove redundant API test for now (conceptually replicated RSpec) --------- Co-authored-by: Jan C. Brammer <jan.c.brammer@gmail.com>
mekkyz
pushed a commit
that referenced
this pull request
Sep 21, 2023
* create user test and researchplan extended test are added * added identifier to eliminate flakyness in researcPlan cypress-specs * collections api spec is now added * deleted unnecessary comments from collection_api_spec.cy.js * Remove redundant API test for now (conceptually replicated RSpec) --------- Co-authored-by: Jan C. Brammer <jan.c.brammer@gmail.com>
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
* create user test and researchplan extended test are added * added identifier to eliminate flakyness in researcPlan cypress-specs * collections api spec is now added * deleted unnecessary comments from collection_api_spec.cy.js * Remove redundant API test for now (conceptually replicated RSpec) --------- Co-authored-by: Jan C. Brammer <jan.c.brammer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release